You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/09/26 17:49:27 UTC

[jira] [Commented] (ZOOKEEPER-1204) Shorten calls to ZooTrace

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114733#comment-13114733 ] 

jiraposter@reviews.apache.org commented on ZOOKEEPER-1204:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2045/
-----------------------------------------------------------

Review request for zookeeper.


Summary
-------



> Shorten calls to ZooTrace
> -------------------------
>
>                 Key: ZOOKEEPER-1204
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1204
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>         Attachments: ZOOKEEPER-1204.patch
>
>
> The calls to ZooTrace are kind of verbose and contain duplicated logic. This patch makes the calls as short as possible so that they do not distract that much from what's actually going on.
> Calls to LOG.isTraceEnabled() are removed at many places, because this check is done anyways inside ZooTracer. At some places it has been left, to avoid costly message creation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira