You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Anyeling0620 (via GitHub)" <gi...@apache.org> on 2026/10/12 07:48:26 UTC

Re: [PR] fix(frontend-new): pass dayjs values to antd DatePickers (hover currently mutates page state in place) [rocketmq-dashboard]

Anyeling0620 commented on PR #6149:
URL: https://github.com/apache/rocketmq-dashboard/pull/6149#issuecomment-6120010028

   Both asks are handled:
   
   1. The regression test you asked for is in `frontend-new/src/pages/Message/message.datepicker.test.js`
      (commit `e6cd2da`). It renders the Message page, opens the Begin picker, sweeps the mouse across
      its cells, asserts the displayed times are unchanged once the panel closes, and asserts the search
      request carries exactly the displayed begin/end. A/B on this branch: dayjs -> `1 passed`;
      reverting the two picker-bound `useState` calls to `moment()` -> `Expected: "2026-10-12 00:00:00"`,
      `Received: "2033-10-09 00:00:00"` -- the same drift signature you described. `setupTests.js` is
      untouched; the jsdom `matchMedia` stub lives in the test file.
   2. The title scope is `fix(frontend-new):`.
   
   One heads-up if you run the suite there: `frontend-new/src/App.test.js` fails on this branch
   regardless of this change (jest 27 vs. `react-router-dom` v7's exports-only `package.json`), so
   `npm test` stays red for that unrelated reason.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org