You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/05 05:33:46 UTC
[GitHub] [airflow] RosterIn opened a new pull request #15665: relax python-telegram-bot
RosterIn opened a new pull request #15665:
URL: https://github.com/apache/airflow/pull/15665
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #15665: relax python-telegram-bot
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #15665:
URL: https://github.com/apache/airflow/pull/15665#issuecomment-832460281
python-telegram-bot is following semver, and 14.0 will likely be incompatible with 13.x. So maybe `~=13.0` would be better here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15665: relax python-telegram-bot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15665:
URL: https://github.com/apache/airflow/pull/15665#issuecomment-834271273
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #15665: relax python-telegram-bot
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #15665:
URL: https://github.com/apache/airflow/pull/15665#issuecomment-834274694
The doc rendering issue was fixed in #15710. It’d be awesome if you could merge or rebase to the master branch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #15665: relax python-telegram-bot
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #15665:
URL: https://github.com/apache/airflow/pull/15665#issuecomment-832567524
No idea either, but I wouldn’t worry about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15665: relax python-telegram-bot
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15665:
URL: https://github.com/apache/airflow/pull/15665#issuecomment-832809941
This is likely an error that was there at the time you branched off. Can you please rebase this on the latest master just to be sure ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn closed pull request #15665: relax python-telegram-bot
Posted by GitBox <gi...@apache.org>.
RosterIn closed pull request #15665:
URL: https://github.com/apache/airflow/pull/15665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15665: relax python-telegram-bot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15665:
URL: https://github.com/apache/airflow/pull/15665#issuecomment-832434992
[The Workflow run](https://github.com/apache/airflow/actions/runs/812373761) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on pull request #15665: relax python-telegram-bot
Posted by GitBox <gi...@apache.org>.
RosterIn commented on pull request #15665:
URL: https://github.com/apache/airflow/pull/15665#issuecomment-832707970
@potiuk can it be merged ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on pull request #15665: relax python-telegram-bot
Posted by GitBox <gi...@apache.org>.
RosterIn commented on pull request #15665:
URL: https://github.com/apache/airflow/pull/15665#issuecomment-832506886
I get failure on doc build but I didn't change any docs nor I changed anything related to `gcp.rst`?
```
############################## Start docs build errors summary ##############################
============================== apache-airflow-providers-google ==============================
------------------------------ Error 1 --------------------
WARNING: Could not lex literal_block as "terraform". Highlighting skipped.
File path: apache-airflow-providers-google/connections/gcp.rst (178)
173 | ``Service Account Token Creator`` role granted on account A, and account A has this role on account
174 | B, then we are able to impersonate account B.
175 |
176 | For example, with the following ``terraform`` setup...
177 |
>178 | .. code-block:: terraform
179 |
180 | terraform {
181 | required_version = "> 0.11.14"
182 | }
183 | provider "google" {}
############################## End docs build errors summary ##############################
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org