[GitHub] [hbase] bharathv commented on a change in pull request #736: HBASE-23182 The create-release scripts are broken

[GitBox <gi...@apache.org>]

bharathv commented on a change in pull request #736: HBASE-23182 The create-release scripts are broken
URL: https://github.com/apache/hbase/pull/736#discussion_r347559660
 
 

 ##########
 File path: dev-support/create-release/release-util.sh
 ##########
 @@ -378,8 +378,8 @@ make_binary_release() {
 
   # Check there is a bin gz output. The build may not produce one: e.g. hbase-thirdparty.
   f_bin_tgz="./${PROJECT}-assembly/target/${basename}*-bin.tar.gz"
-  if test -f "${f_bin_tgz}"; then
-    cp "${f_bin_tgz}" ..
+  if ls ${f_bin_tgz} &>/dev/null; then
 
 Review comment:
   nit: this is also true if ${f_bin_tgz} is a directory. I think a stronger check is [[ -f ${f_bin_tgz}]] (very similar to what it was before) and you can get rid of /dev/null

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services