You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/28 07:43:58 UTC

[GitHub] [shardingsphere] xuup opened a new pull request, #19640: fix issue #18528

xuup opened a new pull request, #19640:
URL: https://github.com/apache/shardingsphere/pull/19640

   Fixes #18528 
   
   Changes proposed in this pull request:
   - modify  method ```create()``` in MySQLAdminExecutorCreator, add logic about checking count of params , not just consider the first parameter.
   -
   My test case as follow in my code:
   ```
   mysql> select version(), @@sql_mode;
   ```
   
   ##### before
   
   <img width="394" alt="image" src="https://user-images.githubusercontent.com/33018640/181413979-c5b6aacd-eac9-429e-821d-23f02f2d55d2.png">
   
   ###### now
   <img width="956" alt="image" src="https://user-images.githubusercontent.com/33018640/181414045-556f31f0-e755-4993-8941-04339a3f6743.png">
   
   ```
   mysql> select current_user(), @@sql_mode;
   ```
   
   ##### before
   <img width="367" alt="image" src="https://user-images.githubusercontent.com/33018640/181414169-6ecef06d-2d6f-4002-94df-0f80a241e74f.png">
   
   ##### now
   <img width="984" alt="image" src="https://user-images.githubusercontent.com/33018640/181414259-86d8422a-482e-439c-98c1-1559bfdaa74c.png">
   
   and it doesn't affect the existing logic
   
   <img width="263" alt="image" src="https://user-images.githubusercontent.com/33018640/181414368-06b338d7-53c2-4bce-b2d2-2f80277f4d09.png">
   
   <img width="399" alt="image" src="https://user-images.githubusercontent.com/33018640/181414730-4a85917e-1556-4eba-9997-cbe6cbb8b546.png">
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] xuup commented on pull request #19640: fix issue #18528

Posted by GitBox <gi...@apache.org>.
xuup commented on PR #19640:
URL: https://github.com/apache/shardingsphere/pull/19640#issuecomment-1197817646

   > Hi @xuup Thanks for your contribution, please resolve conflicts.
   
   Ok, I have resolved conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN merged pull request #19640: fix issue #18528

Posted by GitBox <gi...@apache.org>.
TeslaCN merged PR #19640:
URL: https://github.com/apache/shardingsphere/pull/19640


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #19640: fix issue #18528

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19640:
URL: https://github.com/apache/shardingsphere/pull/19640#issuecomment-1197960449

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19640?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19640](https://codecov.io/gh/apache/shardingsphere/pull/19640?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9e99c3) into [master](https://codecov.io/gh/apache/shardingsphere/commit/57c9ba82889b9f5ae23f14cfe38a0d56a964f7fe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (57c9ba8) will **decrease** coverage by `0.20%`.
   > The diff coverage is `47.77%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #19640      +/-   ##
   ============================================
   - Coverage     60.20%   60.00%   -0.21%     
   + Complexity     2397     2385      -12     
   ============================================
     Files          3840     3843       +3     
     Lines         54677    54766      +89     
     Branches       7645     7659      +14     
   ============================================
   - Hits          32917    32860      -57     
   - Misses        18928    19088     +160     
   + Partials       2832     2818      -14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19640?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sphere/dbdiscovery/rule/DatabaseDiscoveryRule.java](https://codecov.io/gh/apache/shardingsphere/pull/19640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9ydWxlL0RhdGFiYXNlRGlzY292ZXJ5UnVsZS5qYXZh) | `60.91% <0.00%> (-5.34%)` | :arrow_down: |
   | [...apache/shardingsphere/infra/hint/SQLHintUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/19640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9oaW50L1NRTEhpbnRVdGlscy5qYXZh) | `85.71% <0.00%> (-7.15%)` | :arrow_down: |
   | [...e/scenario/rulealtered/RuleAlteredJobPreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/19640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL3J1bGVhbHRlcmVkL1J1bGVBbHRlcmVkSm9iUHJlcGFyZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...le/core/strategy/type/ClusterScheduleStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/19640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjaGVkdWxlL2NvcmUvc3RyYXRlZ3kvdHlwZS9DbHVzdGVyU2NoZWR1bGVTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...core/strategy/type/StandaloneScheduleStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/19640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjaGVkdWxlL2NvcmUvc3RyYXRlZ3kvdHlwZS9TdGFuZGFsb25lU2NoZWR1bGVTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ingsphere/mode/process/ShowProcessListManager.java](https://codecov.io/gh/apache/shardingsphere/pull/19640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcHJvY2Vzcy9TaG93UHJvY2Vzc0xpc3RNYW5hZ2VyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...e/mode/process/lock/ShowProcessListSimpleLock.java](https://codecov.io/gh/apache/shardingsphere/pull/19640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcHJvY2Vzcy9sb2NrL1Nob3dQcm9jZXNzTGlzdFNpbXBsZUxvY2suamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../shardingsphere/mode/process/node/ProcessNode.java](https://codecov.io/gh/apache/shardingsphere/pull/19640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcHJvY2Vzcy9ub2RlL1Byb2Nlc3NOb2RlLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../process/subscriber/ProcessRegistrySubscriber.java](https://codecov.io/gh/apache/shardingsphere/pull/19640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcHJvY2Vzcy9zdWJzY3JpYmVyL1Byb2Nlc3NSZWdpc3RyeVN1YnNjcmliZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../coordinator/ClusterContextManagerCoordinator.java](https://codecov.io/gh/apache/shardingsphere/pull/19640/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9DbHVzdGVyQ29udGV4dE1hbmFnZXJDb29yZGluYXRvci5qYXZh) | `77.27% <0.00%> (-3.68%)` | :arrow_down: |
   | ... and [30 more](https://codecov.io/gh/apache/shardingsphere/pull/19640/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on pull request #19640: fix issue #18528

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #19640:
URL: https://github.com/apache/shardingsphere/pull/19640#issuecomment-1197792742

   Hi @xuup
   Thanks for your contribution, please resolve conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org