You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Animesh Chaturvedi <an...@citrix.com> on 2013/11/07 19:26:10 UTC
Reviewboard needs your attention
There are large number of patches in review board. I went through some of them and followed up and closed out few that are already checked in, but the list is huge. Given that we are approaching the 4.3 feature freeze tomorrow if you have submitted patches and are still pending reviews please reach out to your reviewers. If you have received feedback on your patch please provide an updated patch. Reviewers take a moment to review the patches under your name and help clear up the reviews.
If you are unsure how to help please check Review Board Guidelines [1]
[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines
Re: Reviewboard needs your attention
Posted by Sebastien Goasguen <ru...@gmail.com>.
I hate to move deadline, but it might be good to have couple days to try to clean review board.
-Sebastien
On 7 Nov 2013, at 19:26, Animesh Chaturvedi <an...@citrix.com> wrote:
> There are large number of patches in review board. I went through some of them and followed up and closed out few that are already checked in, but the list is huge. Given that we are approaching the 4.3 feature freeze tomorrow if you have submitted patches and are still pending reviews please reach out to your reviewers. If you have received feedback on your patch please provide an updated patch. Reviewers take a moment to review the patches under your name and help clear up the reviews.
>
>
> If you are unsure how to help please check Review Board Guidelines [1]
>
> [1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines
Re: Reviewboard needs your attention
Posted by Mike Tutkowski <mi...@solidfire.com>.
Hi Animesh,
I get the same results using Firefox.
I assume there are supposed to be buttons to the left of the Review button?
If I make a new Review Request, I see more buttons.
Thanks
On Fri, Nov 8, 2013 at 11:28 AM, Animesh Chaturvedi <
animesh.chaturvedi@citrix.com> wrote:
> Mike is this the only review that you cannot see, or it's a general
> problem you are seeing with reviewboard. May be try another browser
>
> > -----Original Message-----
> > From: Mike Tutkowski [mailto:mike.tutkowski@solidfire.com]
> > Sent: Friday, November 08, 2013 4:47 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Reviewboard needs your attention
> >
> > This is what I see when logged in:
> >
> > http://i.imgur.com/RZvXuy1.png
> >
> > Am I missing something?
> >
> > Thanks!
> >
> >
> > On Thu, Nov 7, 2013 at 10:01 PM, Animesh Chaturvedi <
> > animesh.chaturvedi@citrix.com> wrote:
> >
> > > I can see it fine, were you logged in at that time
> > >
> > > > -----Original Message-----
> > > > From: Mike Tutkowski [mailto:mike.tutkowski@solidfire.com]
> > > > Sent: Thursday, November 07, 2013 6:03 PM
> > > > To: dev@cloudstack.apache.org
> > > > Subject: Re: Reviewboard needs your attention
> > > >
> > > > Hi Animesh,
> > > >
> > > > For whatever reason, I can no longer edit
> > > > https://reviews.apache.org/r/13865/.
> > > >
> > > > Any thoughts on this?
> > > >
> > > > Thanks!
> > > >
> > > >
> > > > On Thu, Nov 7, 2013 at 6:41 PM, Nguyen Anh Tu <ng...@gmail.com>
> > wrote:
> > > >
> > > > > 2013/11/8 Animesh Chaturvedi <an...@citrix.com>
> > > > >
> > > > > > Given that we are approaching the 4.3 feature freeze tomorrow if
> > > > > > you have submitted patches and are still pending reviews please
> > > > > > reach out to your reviewers
> > > > >
> > > > >
> > > > > Dear Sebastien & Hugo,
> > > > >
> > > > > I have two pending patches on review board need to review:
> > > > >
> > > > > Rebase OVS (sdnextensions branch) to master branch:
> > > > > https://reviews.apache.org/r/15205/
> > > > > AutoScaling without NetScaler: https://reviews.apache.org/r/14628/
> > > > >
> > > > > Thanks,
> > > > >
> > > > >
> > > > > --
> > > > >
> > > > > N.g.U.y.e.N.A.n.H.t.U
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > *Mike Tutkowski*
> > > > *Senior CloudStack Developer, SolidFire Inc.*
> > > > e: mike.tutkowski@solidfire.com
> > > > o: 303.746.7302
> > > > Advancing the way the world uses the
> > > > cloud<http://solidfire.com/solution/overview/?video=play>
> > > > *(tm)*
> > >
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkowski@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud<http://solidfire.com/solution/overview/?video=play>
> > *(tm)*
>
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud<http://solidfire.com/solution/overview/?video=play>
*™*
RE: Reviewboard needs your attention
Posted by Animesh Chaturvedi <an...@citrix.com>.
Mike is this the only review that you cannot see, or it's a general problem you are seeing with reviewboard. May be try another browser
> -----Original Message-----
> From: Mike Tutkowski [mailto:mike.tutkowski@solidfire.com]
> Sent: Friday, November 08, 2013 4:47 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Reviewboard needs your attention
>
> This is what I see when logged in:
>
> http://i.imgur.com/RZvXuy1.png
>
> Am I missing something?
>
> Thanks!
>
>
> On Thu, Nov 7, 2013 at 10:01 PM, Animesh Chaturvedi <
> animesh.chaturvedi@citrix.com> wrote:
>
> > I can see it fine, were you logged in at that time
> >
> > > -----Original Message-----
> > > From: Mike Tutkowski [mailto:mike.tutkowski@solidfire.com]
> > > Sent: Thursday, November 07, 2013 6:03 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: Re: Reviewboard needs your attention
> > >
> > > Hi Animesh,
> > >
> > > For whatever reason, I can no longer edit
> > > https://reviews.apache.org/r/13865/.
> > >
> > > Any thoughts on this?
> > >
> > > Thanks!
> > >
> > >
> > > On Thu, Nov 7, 2013 at 6:41 PM, Nguyen Anh Tu <ng...@gmail.com>
> wrote:
> > >
> > > > 2013/11/8 Animesh Chaturvedi <an...@citrix.com>
> > > >
> > > > > Given that we are approaching the 4.3 feature freeze tomorrow if
> > > > > you have submitted patches and are still pending reviews please
> > > > > reach out to your reviewers
> > > >
> > > >
> > > > Dear Sebastien & Hugo,
> > > >
> > > > I have two pending patches on review board need to review:
> > > >
> > > > Rebase OVS (sdnextensions branch) to master branch:
> > > > https://reviews.apache.org/r/15205/
> > > > AutoScaling without NetScaler: https://reviews.apache.org/r/14628/
> > > >
> > > > Thanks,
> > > >
> > > >
> > > > --
> > > >
> > > > N.g.U.y.e.N.A.n.H.t.U
> > > >
> > >
> > >
> > >
> > > --
> > > *Mike Tutkowski*
> > > *Senior CloudStack Developer, SolidFire Inc.*
> > > e: mike.tutkowski@solidfire.com
> > > o: 303.746.7302
> > > Advancing the way the world uses the
> > > cloud<http://solidfire.com/solution/overview/?video=play>
> > > *(tm)*
> >
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud<http://solidfire.com/solution/overview/?video=play>
> *(tm)*
Re: Reviewboard needs your attention
Posted by Mike Tutkowski <mi...@solidfire.com>.
This is what I see when logged in:
http://i.imgur.com/RZvXuy1.png
Am I missing something?
Thanks!
On Thu, Nov 7, 2013 at 10:01 PM, Animesh Chaturvedi <
animesh.chaturvedi@citrix.com> wrote:
> I can see it fine, were you logged in at that time
>
> > -----Original Message-----
> > From: Mike Tutkowski [mailto:mike.tutkowski@solidfire.com]
> > Sent: Thursday, November 07, 2013 6:03 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Reviewboard needs your attention
> >
> > Hi Animesh,
> >
> > For whatever reason, I can no longer edit
> > https://reviews.apache.org/r/13865/.
> >
> > Any thoughts on this?
> >
> > Thanks!
> >
> >
> > On Thu, Nov 7, 2013 at 6:41 PM, Nguyen Anh Tu <ng...@gmail.com> wrote:
> >
> > > 2013/11/8 Animesh Chaturvedi <an...@citrix.com>
> > >
> > > > Given that we are approaching the 4.3 feature freeze tomorrow if you
> > > > have submitted patches and are still pending reviews please reach
> > > > out to your reviewers
> > >
> > >
> > > Dear Sebastien & Hugo,
> > >
> > > I have two pending patches on review board need to review:
> > >
> > > Rebase OVS (sdnextensions branch) to master branch:
> > > https://reviews.apache.org/r/15205/
> > > AutoScaling without NetScaler: https://reviews.apache.org/r/14628/
> > >
> > > Thanks,
> > >
> > >
> > > --
> > >
> > > N.g.U.y.e.N.A.n.H.t.U
> > >
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkowski@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud<http://solidfire.com/solution/overview/?video=play>
> > *(tm)*
>
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud<http://solidfire.com/solution/overview/?video=play>
*™*
RE: Reviewboard needs your attention
Posted by Animesh Chaturvedi <an...@citrix.com>.
I can see it fine, were you logged in at that time
> -----Original Message-----
> From: Mike Tutkowski [mailto:mike.tutkowski@solidfire.com]
> Sent: Thursday, November 07, 2013 6:03 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Reviewboard needs your attention
>
> Hi Animesh,
>
> For whatever reason, I can no longer edit
> https://reviews.apache.org/r/13865/.
>
> Any thoughts on this?
>
> Thanks!
>
>
> On Thu, Nov 7, 2013 at 6:41 PM, Nguyen Anh Tu <ng...@gmail.com> wrote:
>
> > 2013/11/8 Animesh Chaturvedi <an...@citrix.com>
> >
> > > Given that we are approaching the 4.3 feature freeze tomorrow if you
> > > have submitted patches and are still pending reviews please reach
> > > out to your reviewers
> >
> >
> > Dear Sebastien & Hugo,
> >
> > I have two pending patches on review board need to review:
> >
> > Rebase OVS (sdnextensions branch) to master branch:
> > https://reviews.apache.org/r/15205/
> > AutoScaling without NetScaler: https://reviews.apache.org/r/14628/
> >
> > Thanks,
> >
> >
> > --
> >
> > N.g.U.y.e.N.A.n.H.t.U
> >
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud<http://solidfire.com/solution/overview/?video=play>
> *(tm)*
Re: Reviewboard needs your attention
Posted by Mike Tutkowski <mi...@solidfire.com>.
Hi Animesh,
For whatever reason, I can no longer edit
https://reviews.apache.org/r/13865/.
Any thoughts on this?
Thanks!
On Thu, Nov 7, 2013 at 6:41 PM, Nguyen Anh Tu <ng...@gmail.com> wrote:
> 2013/11/8 Animesh Chaturvedi <an...@citrix.com>
>
> > Given that we are approaching the 4.3 feature freeze tomorrow if you have
> > submitted patches and are still pending reviews please reach out to your
> > reviewers
>
>
> Dear Sebastien & Hugo,
>
> I have two pending patches on review board need to review:
>
> Rebase OVS (sdnextensions branch) to master branch:
> https://reviews.apache.org/r/15205/
> AutoScaling without NetScaler: https://reviews.apache.org/r/14628/
>
> Thanks,
>
>
> --
>
> N.g.U.y.e.N.A.n.H.t.U
>
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud<http://solidfire.com/solution/overview/?video=play>
*™*
Re: Reviewboard needs your attention
Posted by Nguyen Anh Tu <ng...@gmail.com>.
2013/11/8 Animesh Chaturvedi <an...@citrix.com>
> Given that we are approaching the 4.3 feature freeze tomorrow if you have
> submitted patches and are still pending reviews please reach out to your
> reviewers
Dear Sebastien & Hugo,
I have two pending patches on review board need to review:
Rebase OVS (sdnextensions branch) to master branch:
https://reviews.apache.org/r/15205/
AutoScaling without NetScaler: https://reviews.apache.org/r/14628/
Thanks,
--
N.g.U.y.e.N.A.n.H.t.U