You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/07/09 04:14:09 UTC
[GitHub] [geode] mhansonp commented on a change in pull request #5354: Feature/geode 8334
mhansonp commented on a change in pull request #5354:
URL: https://github.com/apache/geode/pull/5354#discussion_r451953009
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveAllPRMessage.java
##########
@@ -532,6 +537,9 @@ public boolean doLocalRemoveAll(PartitionedRegion r, InternalDistributedMember e
} catch (RegionDestroyedException e) {
ds.checkRegionDestroyedOnBucket(bucketRegion, true, e);
} finally {
+ if (rvvLocked) {
+ bucketRegion.unlockRVVForBulkOp();
+ }
Review comment:
Should you be setting rvvLocked to false?
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PutAllPRMessage.java
##########
@@ -523,6 +528,9 @@ public boolean doLocalPutAll(PartitionedRegion r, InternalDistributedMember even
} catch (RegionDestroyedException e) {
ds.checkRegionDestroyedOnBucket(bucketRegion, true, e);
} finally {
+ if (rvvLocked) {
+ bucketRegion.unlockRVVForBulkOp();
+ }
Review comment:
should rvvLocked be set to false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org