You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/09/01 13:56:05 UTC

[GitHub] [zeppelin] jaegwonseo opened a new pull request, #4456: Add custom labels to k8s interpreter

jaegwonseo opened a new pull request, #4456:
URL: https://github.com/apache/zeppelin/pull/4456

   ### What type of PR is it?
   to run interpreter on eks fargate, add custom labels to k8s interpreter 
   
   ### How should this be tested?
   add zeppelin.k8s.interpreter.customLabels to zeppelin-site.xml and deploy on eks 
   
   ### Screenshots (if appropriate)
   custom label k1:v1 is attached
   ![스크린샷 2022-09-01 오후 10 55 06](https://user-images.githubusercontent.com/90180644/187931803-fed0a954-dde1-4231-8ba0-c83998ebda6e.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] jaegwonseo closed pull request #4456: Add custom labels to k8s interpreter

Posted by GitBox <gi...@apache.org>.
jaegwonseo closed pull request #4456: Add custom labels to k8s interpreter
URL: https://github.com/apache/zeppelin/pull/4456


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4456: Add custom labels to k8s interpreter

Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4456:
URL: https://github.com/apache/zeppelin/pull/4456#issuecomment-1234344984

   What prevents you from including your own labels in your Jinja template?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] jaegwonseo commented on pull request #4456: Add custom labels to k8s interpreter

Posted by GitBox <gi...@apache.org>.
jaegwonseo commented on PR #4456:
URL: https://github.com/apache/zeppelin/pull/4456#issuecomment-1234366331

   In order to deploy with different settings to n k8s clusters, different zeppelin-site.xml files are mounted and used for each cluster.
   
   If Jinja template also needs to be created for each cluster, it seems better to manage it at once in zeppelin-site.xml because the number of management points increases.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4456: Add custom labels to k8s interpreter

Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4456:
URL: https://github.com/apache/zeppelin/pull/4456#issuecomment-1235386873

   I am against the MR, because today it is about labels, tomorrow in annotations and the day after tomorrow about additional initContainers. Please adjust your Jinja2 template. This can be mounted wonderfully into the pod using ConfigMap.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] ebuildy commented on pull request #4456: Add custom labels to k8s interpreter

Posted by GitBox <gi...@apache.org>.
ebuildy commented on PR #4456:
URL: https://github.com/apache/zeppelin/pull/4456#issuecomment-1235690039

   Templating is very powerfull, you can use jinja conditionnal tags to have some labels for a particular interpreter etc...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] jaegwonseo commented on pull request #4456: Add custom labels to k8s interpreter

Posted by GitBox <gi...@apache.org>.
jaegwonseo commented on PR #4456:
URL: https://github.com/apache/zeppelin/pull/4456#issuecomment-1236325017

   > I am against the MR, because today it is about labels, tomorrow in annotations and the day after tomorrow about additional initContainers. Please adjust your Jinja2 template. This can be mounted wonderfully into the pod using ConfigMap.
   
   @Reamer  
   I think your opinion is more correct.
   It would be better to mount the Jinja2 template. 
   
   @ebuildy 
   Unless adding all the k8s options to the Jinja2 template, it would be better to leave it alone.
   
   i'm gonna close this pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org