You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2015/11/16 01:15:16 UTC

Review Request 40336: SQOOP-2689 Sqoop2: RESTiliency: InvalidRESTCallsTest is using wrong order when serializing data to request

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40336/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2689
    https://issues.apache.org/jira/browse/SQOOP-2689


Repository: sqoop-sqoop2


Description
-------

Corrected order.


Diffs
-----

  test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java d083d37 

Diff: https://reviews.apache.org/r/40336/diff/


Testing
-------

The integration test seems to be passing.


Thanks,

Jarek Cecho


Re: Review Request 40336: SQOOP-2689 Sqoop2: RESTiliency: InvalidRESTCallsTest is using wrong order when serializing data to request

Posted by Jarek Cecho <ja...@apache.org>.

> On Nov. 16, 2015, 10:17 p.m., Abraham Fine wrote:
> > test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java, line 263
> > <https://reviews.apache.org/r/40336/diff/1/?file=1125890#file1125890line263>
> >
> >     a little concerning that this was broken and it did not impact the result of the tests.
> >     
> >     it seems that we are not actually testing the content of these responses. so why do we need to write them to a dataoutputstream?

The reason for that is that so far neigher of the REST-specific tests is actually testing sending data over - that is something that I'm working on right now and that is how I found this problem :)


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40336/#review106748
-----------------------------------------------------------


On Nov. 16, 2015, 12:15 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40336/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 12:15 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2689
>     https://issues.apache.org/jira/browse/SQOOP-2689
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Corrected order.
> 
> 
> Diffs
> -----
> 
>   test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java d083d37 
> 
> Diff: https://reviews.apache.org/r/40336/diff/
> 
> 
> Testing
> -------
> 
> The integration test seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request 40336: SQOOP-2689 Sqoop2: RESTiliency: InvalidRESTCallsTest is using wrong order when serializing data to request

Posted by Abraham Fine <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40336/#review106748
-----------------------------------------------------------



test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java (line 263)
<https://reviews.apache.org/r/40336/#comment165505>

    a little concerning that this was broken and it did not impact the result of the tests.
    
    it seems that we are not actually testing the content of these responses. so why do we need to write them to a dataoutputstream?


- Abraham Fine


On Nov. 16, 2015, 12:15 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40336/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 12:15 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2689
>     https://issues.apache.org/jira/browse/SQOOP-2689
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Corrected order.
> 
> 
> Diffs
> -----
> 
>   test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java d083d37 
> 
> Diff: https://reviews.apache.org/r/40336/diff/
> 
> 
> Testing
> -------
> 
> The integration test seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request 40336: SQOOP-2689 Sqoop2: RESTiliency: InvalidRESTCallsTest is using wrong order when serializing data to request

Posted by Abraham Fine <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40336/#review106751
-----------------------------------------------------------

Ship it!


Ship It!

- Abraham Fine


On Nov. 16, 2015, 12:15 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40336/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 12:15 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2689
>     https://issues.apache.org/jira/browse/SQOOP-2689
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Corrected order.
> 
> 
> Diffs
> -----
> 
>   test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java d083d37 
> 
> Diff: https://reviews.apache.org/r/40336/diff/
> 
> 
> Testing
> -------
> 
> The integration test seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>