[jira] [Updated] (PIG-4595) Fix unit test failures about TestFRJoinNullValue in spark mode

["liyunzhang_intel (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PIG-4595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

liyunzhang_intel updated PIG-4595:
----------------------------------
    Attachment: PIG-4595.patch

[~mohitsabharwal]:
in PIG-4595.patch, changes are:
1.change the key type  in FRJoinConverter.java from "Object" to "IndexedKey"
to avoid considering the null value from table a and table b same when table a and table b is frjoined.
2. make IndexedKey a public class not a static class inside GlobalRearrangeConverter.java.




> Fix unit test failures about TestFRJoinNullValue in spark mode
> --------------------------------------------------------------
>
>                 Key: PIG-4595
>                 URL: https://issues.apache.org/jira/browse/PIG-4595
>             Project: Pig
>          Issue Type: Sub-task
>          Components: spark
>            Reporter: liyunzhang_intel
>            Assignee: liyunzhang_intel
>             Fix For: spark-branch
>
>         Attachments: PIG-4595.patch
>
>
> based on f9a50f3, using following command to test TestFRJoinNullValue：
> ant -Dtestcase=TestFRJoinNullValue -Dexectype=spark  -Dhadoopversion=23  test 
> following ut fail:
> • org.apache.pig.test.TestFRJoinNullValue.testTupleLeftNullMatch
> • org.apache.pig.test.TestFRJoinNullValue.testLeftNullMatch
> • org.apache.pig.test.TestFRJoinNullValue.testTupleNullMatch
> • org.apache.pig.test.TestFRJoinNullValue.testNullMatch
> The reason why these unit test fail is because null value from table a and table b are considered same when table a fr join table b.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)