You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael Busch (JIRA)" <ji...@apache.org> on 2009/07/25 02:09:14 UTC
[jira] Created: (LUCENE-1759) Implement TokenStream.end() in
contrib TokenStreams
Implement TokenStream.end() in contrib TokenStreams
---------------------------------------------------
Key: LUCENE-1759
URL: https://issues.apache.org/jira/browse/LUCENE-1759
Project: Lucene - Java
Issue Type: Task
Reporter: Michael Busch
Assignee: Michael Busch
Priority: Minor
Fix For: 2.9
See LUCENE-1448. Mike's patch there already contains the necessary fixes.
I'll attach a patch here as soon as LUCENE-1460 is committed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1759) Implement TokenStream.end() in
contrib TokenStreams
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737966#action_12737966 ]
Michael Busch commented on LUCENE-1759:
---------------------------------------
Now that LUCENE-1460 is committed I can create a patch here soon.
> Implement TokenStream.end() in contrib TokenStreams
> ---------------------------------------------------
>
> Key: LUCENE-1759
> URL: https://issues.apache.org/jira/browse/LUCENE-1759
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Michael Busch
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
>
> See LUCENE-1448. Mike's patch there already contains the necessary fixes.
> I'll attach a patch here as soon as LUCENE-1460 is committed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1759) Implement TokenStream.end() in
contrib TokenStreams
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737998#action_12737998 ]
Michael Busch commented on LUCENE-1759:
---------------------------------------
Do you mean the entry for LUCENE-1448? I added that as new feature, because the end() method is new and can be used to perform any end-of-stream operations. In this particular case it's used to fix the offset bug. Hmm, maybe I should have made two entries... feel free to move it if you think it doesn't belong there.
> Implement TokenStream.end() in contrib TokenStreams
> ---------------------------------------------------
>
> Key: LUCENE-1759
> URL: https://issues.apache.org/jira/browse/LUCENE-1759
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Michael Busch
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1759.patch
>
>
> See LUCENE-1448. Mike's patch there already contains the necessary fixes.
> I'll attach a patch here as soon as LUCENE-1460 is committed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1759) Implement TokenStream.end() in
contrib TokenStreams
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch updated LUCENE-1759:
----------------------------------
Attachment: lucene-1759.patch
I converted Mike's patch from LUCENE-1448 to use the new end() method.
All tests pass. I will commit this shortly.
> Implement TokenStream.end() in contrib TokenStreams
> ---------------------------------------------------
>
> Key: LUCENE-1759
> URL: https://issues.apache.org/jira/browse/LUCENE-1759
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Michael Busch
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1759.patch
>
>
> See LUCENE-1448. Mike's patch there already contains the necessary fixes.
> I'll attach a patch here as soon as LUCENE-1460 is committed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1759) Implement TokenStream.end() in
contrib TokenStreams
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch resolved LUCENE-1759.
-----------------------------------
Resolution: Fixed
Committed revision 799968.
> Implement TokenStream.end() in contrib TokenStreams
> ---------------------------------------------------
>
> Key: LUCENE-1759
> URL: https://issues.apache.org/jira/browse/LUCENE-1759
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Michael Busch
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1759.patch
>
>
> See LUCENE-1448. Mike's patch there already contains the necessary fixes.
> I'll attach a patch here as soon as LUCENE-1460 is committed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1759) Implement TokenStream.end() in
contrib TokenStreams
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737979#action_12737979 ]
Mark Miller commented on LUCENE-1759:
-------------------------------------
This is under new features in changes, but wasn't this issue a bug fix?
> Implement TokenStream.end() in contrib TokenStreams
> ---------------------------------------------------
>
> Key: LUCENE-1759
> URL: https://issues.apache.org/jira/browse/LUCENE-1759
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Michael Busch
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1759.patch
>
>
> See LUCENE-1448. Mike's patch there already contains the necessary fixes.
> I'll attach a patch here as soon as LUCENE-1460 is committed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1759) Implement TokenStream.end() in
contrib TokenStreams
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738081#action_12738081 ]
Mark Miller commented on LUCENE-1759:
-------------------------------------
bq. In this particular case it's used to fix the offset bug. Hmm, maybe I should have made two entries...
+1. Its not that I feel it doesn't belong there, I just want people reading changes to know that bug is fixed - its bitten a couple people in the past (multifields/highlighter). Koji has been waiting patiently for the fix for some time for one ;) Its not a big deal for sure, but I think we should just put it twice - I can copy it to the bug section as well. I've seen an issue make 3 sections, so 2 should be no problem :)
> Implement TokenStream.end() in contrib TokenStreams
> ---------------------------------------------------
>
> Key: LUCENE-1759
> URL: https://issues.apache.org/jira/browse/LUCENE-1759
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Michael Busch
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1759.patch
>
>
> See LUCENE-1448. Mike's patch there already contains the necessary fixes.
> I'll attach a patch here as soon as LUCENE-1460 is committed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-1759) Implement
TokenStream.end() in contrib TokenStreams
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738081#action_12738081 ]
Mark Miller edited comment on LUCENE-1759 at 8/2/09 7:46 AM:
-------------------------------------------------------------
bq. In this particular case it's used to fix the offset bug. Hmm, maybe I should have made two entries...
+1. Its not that I feel it doesn't belong there, I just want people reading changes to know that bug is fixed - its bitten a couple people in the past (multifields/highlighter). Koji has been waiting patiently for the fix for some time for one ;) Its not a big deal for sure, but I think we should just put it twice - I can copy it to the bug section as well. I've seen an issue make 3 sections, so 2 should be no problem :)
Apologize for being in the wrong issue again by the way - finding myself in the wrong place a lot lately.
was (Author: markrmiller@gmail.com):
bq. In this particular case it's used to fix the offset bug. Hmm, maybe I should have made two entries...
+1. Its not that I feel it doesn't belong there, I just want people reading changes to know that bug is fixed - its bitten a couple people in the past (multifields/highlighter). Koji has been waiting patiently for the fix for some time for one ;) Its not a big deal for sure, but I think we should just put it twice - I can copy it to the bug section as well. I've seen an issue make 3 sections, so 2 should be no problem :)
> Implement TokenStream.end() in contrib TokenStreams
> ---------------------------------------------------
>
> Key: LUCENE-1759
> URL: https://issues.apache.org/jira/browse/LUCENE-1759
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Michael Busch
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1759.patch
>
>
> See LUCENE-1448. Mike's patch there already contains the necessary fixes.
> I'll attach a patch here as soon as LUCENE-1460 is committed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org