You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by gi...@apache.org on 2026/10/05 08:11:49 UTC
(texera) 01/02: refactor(frontend): remove execution-snapshot leftovers (#8837)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git
commit 1603fd7e92b9c187d922020b0e1f79728d78b30b
Author: Xinyuan Lin <xi...@uci.edu>
AuthorDate: Mon Oct 5 07:43:47 2026 +0000
refactor(frontend): remove execution-snapshot leftovers (#8837)
### What changes were proposed in this PR?
Removes the leftovers of the execution-snapshot column from the workflow
execution-history modal. **−14 lines.** There is no behaviour change.
- **Styles:** the `.version-sample` and `.workflow-snapshot` rules in
`workflow-execution-history.component.scss`. Nothing uses either class:
the template has no static or dynamic use, the component uses emulated
encapsulation, and no other stylesheet or `::ng-deep` relies on them.
- **Column width:** the `"Workflow Version Sample"` entry in
`customColumnWidth`. `executionsTableHeaders` no longer lists that
column, so the template's `customColumnWidth[column]` lookup never reads
the key.
### History
| | |
| --- | --- |
| **Introduced by** | #1634 (2022-10-04), "Introduce execution
snapshot". It added a "Workflow Version Sample" column showing a
snapshot per execution, styled by these classes and sized by this width
entry |
| **Usage removed by** | #1695 (2022-10-18), "Remove snapshot feature
and fix version pagination". It deleted the column header and the markup
that used both classes, but kept the rules and the width entry |
They have been dead for nearly four years.
### Any related issues, documentation, discussions?
Closes #8836
### How was this PR tested?
No new tests; no spec referenced any of them.
From `frontend/`:
- `npx ng test --watch=false
--include='**/workflow-execution-history.component.spec.ts'
--include='**/admin-execution.component.spec.ts'
--include='**/left-panel.component.spec.ts'`: 3 files, 138 tests, all
pass. The last two specs cover the components that host this modal.
- `yarn format:ci`: clean.
- `npx ng build`: success.
To re-check:
```
git grep -n -E "version-sample|workflow-snapshot|Version Sample" -- frontend # no hits
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---
.../workflow-execution-history.component.scss | 13 -------------
.../workflow-execution-history.component.ts | 1 -
2 files changed, 14 deletions(-)
diff --git a/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.scss b/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.scss
index 5a26bed1c2..67b4d1eb4e 100644
--- a/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.scss
+++ b/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.scss
@@ -32,24 +32,11 @@ nz-table th {
text-align: center;
}
-.version-sample {
- flex-grow: 2;
- text-align: center;
-}
-
.ant-btn {
border: 0;
background-color: transparent;
}
-.workflow-snapshot {
- float: left;
- display: inline;
- border: 1px solid #343a40;
- width: 170px;
- height: 95px;
-}
-
#exection-history-table {
width: 100%;
height: 100%;
diff --git a/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.ts b/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.ts
index 724d9b4de2..e0b1f114d8 100644
--- a/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.ts
+++ b/frontend/src/app/dashboard/component/user/user-workflow/ngbd-modal-workflow-executions/workflow-execution-history.component.ts
@@ -148,7 +148,6 @@ export class WorkflowExecutionHistoryComponent implements OnInit, AfterViewInit
"": "0%",
"Name (ID)": "7%",
"Computing Unit ID": "7%",
- "Workflow Version Sample": "10%",
Avatar: "5.5%",
"Execution Start Time": "9%",
"Execution Completion Time": "10.5%",