[jira] [Comment Edited] (REEF-41) Replace Guava cache usage in core REEF

["Markus Weimer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289537#comment-14289537 ] 

Markus Weimer edited comment on REEF-41 at 1/23/15 5:17 PM:
------------------------------------------------------------

I did a quick scan of the code. Looks good, but it would be good to add JavaDoc to the tests. 

I won't be able to do a deep code review until Monday. It might be good for someone else to do that.


was (Author: markus.weimer):
I did a quick scan of the code. Looks good, but it would be good to add JavaDoc to the tests. 

> Replace Guava cache usage in core REEF
> --------------------------------------
>
>                 Key: REEF-41
>                 URL: https://issues.apache.org/jira/browse/REEF-41
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF
>            Reporter: Brian Cho
>            Assignee: Brian Cho
>
> This sub-Task will deal with removing the non-trivial instance of Guava usage. Specifically:
> ( quoting [~bgchun] )
> NameCache uses a Guava cache. One should be able to cleanly replace it by
> providing a Cache<Identifier, InetSocketAddress> implementation. But this
> requires more effort since NameCache relies on a few neat features of the
> Guava cache.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)