AbstractFileSet/ bug 40722 [was : next release steps ]

[Antoine Levy-Lambert <an...@gmx.de>]

Hi,

the best solution would be to revert my changes in
AbstractFileSet#setupDirectoryScanner(FileScanner, Project),
and change this in mergePatterns :
        PatternSet ps = new PatternSet();
        ps.append(defaultPatterns, p);
to
       ps = defaultPatterns.clone();

the fact that PatternSet#append removes the include/exclude patterns
which are not valid due to if or unless clauses made us lose the
information that
there was an include pattern, leading to "<include if="property"> logic
changed for <javac> since ant 1.6.5"

at this occasion we should add a Clone() method to DataType and to
ProjectComponent.

What do you think ?

Regards,

Antoine

[1] http://issues.apache.org/bugzilla/show_bug.cgi?id=40722.

Antoine Levy-Lambert wrote:
> Hi,
>
> I am pretty sure that Matt will rework my changes.
> AbstractFileset#mergePatterns is called from Sync#removeOrphans, so I
> could not remove it without changing sync.
>
> Regards,
>
> Antoine
>
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org

Re: AbstractFileSet/ bug 40722

[Stefan Bodewig <bo...@apache.org>]

On Sun, 29 Oct 2006, Antoine Levy-Lambert <an...@gmx.de> wrote:

> at this occasion we should add a Clone() method to DataType and to
> ProjectComponent.

In order to have a proper implementation of clone in any datatype we
need to implement it there, true.  DataTypes that don't want to or
can't implement clone will have to override the method as well, though
- so we should allow it to throw a CloneNotSupported exception.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org