You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "Mattmann, Chris A (3980)" <ch...@jpl.nasa.gov> on 2015/08/06 21:32:30 UTC
1.10 release missing license headers noted by Daniel Gruno
From Twitter:
https://paste.apache.org/1CPH
Don’t have to fix now, but would be good to fix for 1.11.
Cheers,
Chris
P.S. Thanks for the catch Daniel!
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Chief Architect
Instrument Software and Science Data Systems Section (398)
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 168-519, Mailstop: 168-527
Email: chris.a.mattmann@nasa.gov
WWW: http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Associate Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Re: 1.10 release missing license headers noted by Daniel Gruno
Posted by David Meikle <lo...@gmail.com>.
Hi Guys,
Apologies for this, I should have picked this up when rolling the release. Echoing Chris’s thanks for the catch on this Daniel.
Was about to go in and add in the plugin but see you’ve done this Nick.
Given the successful VOTE on 1.10, I will push this out unless anyone shouts differently.
Cheers,
Dave
> On 6 Aug 2015, at 20:32, Mattmann, Chris A (3980) <ch...@jpl.nasa.gov> wrote:
>
> From Twitter:
> https://paste.apache.org/1CPH
>
>
> Don’t have to fix now, but would be good to fix for 1.11.
>
> Cheers,
> Chris
>
> P.S. Thanks for the catch Daniel!
>
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> Chris Mattmann, Ph.D.
> Chief Architect
> Instrument Software and Science Data Systems Section (398)
> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
> Office: 168-519, Mailstop: 168-527
> Email: chris.a.mattmann@nasa.gov
> WWW: http://sunset.usc.edu/~mattmann/
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> Adjunct Associate Professor, Computer Science Department
> University of Southern California, Los Angeles, CA 90089 USA
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
>
>
Re: 1.10 release missing license headers noted by Daniel Gruno
Posted by "Mattmann, Chris A (3980)" <ch...@jpl.nasa.gov>.
Chris, Tyler Palsulich, Lewis John McGibbney, Mike Joyce, and
I think a few others :-) I have a postdoc, Ji-Hyun working on
it right now too :-)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Chief Architect
Instrument Software and Science Data Systems Section (398)
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 168-519, Mailstop: 168-527
Email: chris.a.mattmann@nasa.gov
WWW: http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Associate Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
-----Original Message-----
From: Nick Burch <ap...@gagravarr.org>
Reply-To: "dev@tika.apache.org" <de...@tika.apache.org>
Date: Thursday, August 6, 2015 at 3:37 PM
To: "dev@tika.apache.org" <de...@tika.apache.org>
Cc: Daniel Gruno <hu...@apache.org>
Subject: Re: 1.10 release missing license headers noted by Daniel Gruno
>On Thu, 6 Aug 2015, Tom Barber wrote:
>> It works well as well doesn't it.... I mean "hey guys we're missing
>>licence
>> headers" normally I'd probably reply with an expletive, now I can just
>> reply "oh DRAT".....
>>
>> I'll get my coat.
>
>Isn't it Chris saying "oh DRAT"?
>
>Apache Creadur finds a problem, an ASF community project, then the
>community has to fix it
>
>If Chris's DRAT finds it, then Chris has to fix it
>
>Right? ;-)
>
>Nick
Re: 1.10 release missing license headers noted by Daniel Gruno
Posted by Nick Burch <ap...@gagravarr.org>.
On Thu, 6 Aug 2015, Tom Barber wrote:
> It works well as well doesn't it.... I mean "hey guys we're missing licence
> headers" normally I'd probably reply with an expletive, now I can just
> reply "oh DRAT".....
>
> I'll get my coat.
Isn't it Chris saying "oh DRAT"?
Apache Creadur finds a problem, an ASF community project, then the
community has to fix it
If Chris's DRAT finds it, then Chris has to fix it
Right? ;-)
Nick
Re: 1.10 release missing license headers noted by Daniel Gruno
Posted by Tom Barber <to...@meteorite.bi>.
It works well as well doesn't it.... I mean "hey guys we're missing licence
headers" normally I'd probably reply with an expletive, now I can just
reply "oh DRAT".....
I'll get my coat.
On 6 Aug 2015 22:44, "Mattmann, Chris A (3980)" <
chris.a.mattmann@jpl.nasa.gov> wrote:
> -----Original Message-----
>
> From: Nick Burch <ap...@gagravarr.org>
> Reply-To: "dev@tika.apache.org" <de...@tika.apache.org>
> Date: Thursday, August 6, 2015 at 2:25 PM
> To: "dev@tika.apache.org" <de...@tika.apache.org>
> Cc: Daniel Gruno <hu...@apache.org>
> Subject: Re: 1.10 release missing license headers noted by Daniel Gruno
>
> >
> >> Not sure. Will check. Also thinking of upgrading to DRAT (instead of
> >> RAT):
> >>
> >> http://github.com/chrismattmann/drat/
> >
> >Can't you just get voted onto the Creadur PMC then get that pushed
> >upstream? :)
>
> I thought about that - or perhaps going the Incubator route.
> I had a decent community around this that didn’t include the Creadur
> folks.
>
> We’ll see :)
>
> Cheers,
> Chris
>
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> Chris Mattmann, Ph.D.
> Chief Architect
> Instrument Software and Science Data Systems Section (398)
> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
> Office: 168-519, Mailstop: 168-527
> Email: chris.a.mattmann@nasa.gov
> WWW: http://sunset.usc.edu/~mattmann/
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> Adjunct Associate Professor, Computer Science Department
> University of Southern California, Los Angeles, CA 90089 USA
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
>
Re: 1.10 release missing license headers noted by Daniel Gruno
Posted by "Mattmann, Chris A (3980)" <ch...@jpl.nasa.gov>.
-----Original Message-----
From: Nick Burch <ap...@gagravarr.org>
Reply-To: "dev@tika.apache.org" <de...@tika.apache.org>
Date: Thursday, August 6, 2015 at 2:25 PM
To: "dev@tika.apache.org" <de...@tika.apache.org>
Cc: Daniel Gruno <hu...@apache.org>
Subject: Re: 1.10 release missing license headers noted by Daniel Gruno
>
>> Not sure. Will check. Also thinking of upgrading to DRAT (instead of
>> RAT):
>>
>> http://github.com/chrismattmann/drat/
>
>Can't you just get voted onto the Creadur PMC then get that pushed
>upstream? :)
I thought about that - or perhaps going the Incubator route.
I had a decent community around this that didn’t include the Creadur
folks.
We’ll see :)
Cheers,
Chris
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Chief Architect
Instrument Software and Science Data Systems Section (398)
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 168-519, Mailstop: 168-527
Email: chris.a.mattmann@nasa.gov
WWW: http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Associate Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
RE: 1.10 release missing license headers noted by Daniel Gruno
Posted by "Allison, Timothy B." <ta...@mitre.org>.
Never mind. Thank you, Nick!
-----Original Message-----
From: Allison, Timothy B. [mailto:tallison@mitre.org]
Sent: Friday, August 07, 2015 7:19 AM
To: dev@tika.apache.org
Cc: Daniel Gruno <hu...@apache.org>
Subject: RE: 1.10 release missing license headers noted by Daniel Gruno
Doh! I'll fix tika-batch now...my fault.
I'll also fix MosesTranslatorTest and mp4's DirectFileReadDataSource while I'm at it as penance. Sorry...
-----Original Message-----
From: Nick Burch [mailto:apache@gagravarr.org]
Sent: Thursday, August 06, 2015 5:25 PM
To: dev@tika.apache.org
Cc: Daniel Gruno <hu...@apache.org>
Subject: Re: 1.10 release missing license headers noted by Daniel Gruno
On Thu, 6 Aug 2015, Mattmann, Chris A (3980) wrote:
> I think we may have exclusions here since they are test resources?
The tika-parsers/src/test/resources/test-documents/ shouldn't have headers
at all, and the txt.Charset ones are taken from Icu4j so have their
original license header on them, but the rest should do
> Not sure. Will check. Also thinking of upgrading to DRAT (instead of
> RAT):
>
> http://github.com/chrismattmann/drat/
Can't you just get voted onto the Creadur PMC then get that pushed
upstream? :)
Nick
RE: 1.10 release missing license headers noted by Daniel Gruno
Posted by "Allison, Timothy B." <ta...@mitre.org>.
Doh! I'll fix tika-batch now...my fault.
I'll also fix MosesTranslatorTest and mp4's DirectFileReadDataSource while I'm at it as penance. Sorry...
-----Original Message-----
From: Nick Burch [mailto:apache@gagravarr.org]
Sent: Thursday, August 06, 2015 5:25 PM
To: dev@tika.apache.org
Cc: Daniel Gruno <hu...@apache.org>
Subject: Re: 1.10 release missing license headers noted by Daniel Gruno
On Thu, 6 Aug 2015, Mattmann, Chris A (3980) wrote:
> I think we may have exclusions here since they are test resources?
The tika-parsers/src/test/resources/test-documents/ shouldn't have headers
at all, and the txt.Charset ones are taken from Icu4j so have their
original license header on them, but the rest should do
> Not sure. Will check. Also thinking of upgrading to DRAT (instead of
> RAT):
>
> http://github.com/chrismattmann/drat/
Can't you just get voted onto the Creadur PMC then get that pushed
upstream? :)
Nick
Re: 1.10 release missing license headers noted by Daniel Gruno
Posted by Nick Burch <ap...@gagravarr.org>.
On Thu, 6 Aug 2015, Mattmann, Chris A (3980) wrote:
> I think we may have exclusions here since they are test resources?
The tika-parsers/src/test/resources/test-documents/ shouldn't have headers
at all, and the txt.Charset ones are taken from Icu4j so have their
original license header on them, but the rest should do
> Not sure. Will check. Also thinking of upgrading to DRAT (instead of
> RAT):
>
> http://github.com/chrismattmann/drat/
Can't you just get voted onto the Creadur PMC then get that pushed
upstream? :)
Nick
Re: 1.10 release missing license headers noted by Daniel Gruno
Posted by "Mattmann, Chris A (3980)" <ch...@jpl.nasa.gov>.
I think we may have exclusions here since they are test resources?
Not sure. Will check. Also thinking of upgrading to DRAT (instead of
RAT):
http://github.com/chrismattmann/drat/
See all the prezos, etc., there for why.
Cheers,
Chris
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Chief Architect
Instrument Software and Science Data Systems Section (398)
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 168-519, Mailstop: 168-527
Email: chris.a.mattmann@nasa.gov
WWW: http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Associate Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
-----Original Message-----
From: Nick Burch <ap...@gagravarr.org>
Reply-To: "dev@tika.apache.org" <de...@tika.apache.org>
Date: Thursday, August 6, 2015 at 12:43 PM
To: "dev@tika.apache.org" <de...@tika.apache.org>
Cc: Daniel Gruno <hu...@apache.org>
Subject: Re: 1.10 release missing license headers noted by Daniel Gruno
>On Thu, 6 Aug 2015, Mattmann, Chris A (3980) wrote:
>> From Twitter:
>> https://paste.apache.org/1CPH
>>
>> Don’t have to fix now, but would be good to fix for 1.11.
>
>Don't we have Apache Creadur (formerly Rat) setup on the build? If so,
>how
>did it pass? If not, can someone turn it on ASAP? :)
>
>Nick
Re: 1.10 release missing license headers noted by Daniel Gruno
Posted by Nick Burch <ap...@gagravarr.org>.
On Thu, 6 Aug 2015, Mattmann, Chris A (3980) wrote:
> From Twitter:
> https://paste.apache.org/1CPH
>
> Don’t have to fix now, but would be good to fix for 1.11.
Don't we have Apache Creadur (formerly Rat) setup on the build? If so, how
did it pass? If not, can someone turn it on ASAP? :)
Nick