You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2023/04/04 15:54:14 UTC
[GitHub] [superset] kgabryje opened a new pull request, #23576: fix(dashboard): Cross filters badge for cols with verbose names
kgabryje opened a new pull request, #23576:
URL: https://github.com/apache/superset/pull/23576
### SUMMARY
Fixes regression introduced in https://github.com/apache/superset/pull/23509 that caused the filters badge not to appear if cross filter was applied on a column with verbose name.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before (no badge next to pivot table):
<img width="989" alt="image" src="https://user-images.githubusercontent.com/15073128/229848542-0f796e5c-1345-4ead-b115-bfbf3f667f8f.png">
After:
<img width="892" alt="image" src="https://user-images.githubusercontent.com/15073128/229848266-3bdc6e67-d0ef-45a8-ac40-28eed302c74a.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
CC @Always-prog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #23576: fix(dashboard): Cross filters badge for cols with verbose names
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje merged PR #23576:
URL: https://github.com/apache/superset/pull/23576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23576: fix(dashboard): Cross filters badge for cols with verbose names
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23576:
URL: https://github.com/apache/superset/pull/23576#issuecomment-1496308718
## [Codecov](https://codecov.io/gh/apache/superset/pull/23576?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23576](https://codecov.io/gh/apache/superset/pull/23576?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eaa22da) into [master](https://codecov.io/gh/apache/superset/commit/a4d4084d081a4caab17c40ad3d2dd75b463b57ba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4d4084) will **increase** coverage by `0.00%`.
> The diff coverage is `66.66%`.
> :exclamation: Current head eaa22da differs from pull request most recent head 05d64ec. Consider uploading reports for the commit 05d64ec to get more accurate results
```diff
@@ Coverage Diff @@
## master #23576 +/- ##
=======================================
Coverage 67.71% 67.71%
=======================================
Files 1916 1916
Lines 74017 74014 -3
Branches 8041 8039 -2
=======================================
- Hits 50122 50121 -1
+ Misses 21845 21844 -1
+ Partials 2050 2049 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.95% <66.66%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../nativeFilters/FilterBar/CrossFilters/selectors.ts](https://codecov.io/gh/apache/superset/pull/23576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nyb3NzRmlsdGVycy9zZWxlY3RvcnMudHM=) | `9.09% <0.00%> (-0.91%)` | :arrow_down: |
| [...rc/dashboard/components/nativeFilters/selectors.ts](https://codecov.io/gh/apache/superset/pull/23576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc2VsZWN0b3JzLnRz) | `58.26% <ø> (+0.90%)` | :arrow_up: |
| [...nd/src/dashboard/components/FiltersBadge/index.tsx](https://codecov.io/gh/apache/superset/pull/23576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9pbmRleC50c3g=) | `85.71% <100.00%> (+1.09%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org