You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/30 20:45:52 UTC

[GitHub] vandanavk edited a comment on issue #12878: ONNX export: Cleanup

vandanavk edited a comment on issue #12878: ONNX export: Cleanup
URL: https://github.com/apache/incubator-mxnet/pull/12878#issuecomment-434457546
 
 
   @zhreshold I think there's more opportunity for reducing duplicate code. There are 32 operators which don't use attrs and directly create a node. Example: Trigonometric ops, negative, reciprocal etc. I'm thinking of writing a helper to create nodes for such ops. Any thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services