You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/04/29 05:33:56 UTC

[jira] Created: (HBASE-603) When an exception bubbles out of getRegionServerWithRetries, wrap the exception with a RetriesExhaustedException

When an exception bubbles out of getRegionServerWithRetries, wrap the exception with a RetriesExhaustedException
----------------------------------------------------------------------------------------------------------------

                 Key: HBASE-603
                 URL: https://issues.apache.org/jira/browse/HBASE-603
             Project: Hadoop HBase
          Issue Type: New Feature
          Components: client
            Reporter: Bryan Duxbury
            Priority: Minor
             Fix For: 0.2.0


There's always a lot of confusion about what NotServingRegionExceptions and WrongRegionExceptions mean when they come out of the client side. To help alleviate this, I propose that we create a new exception type called RetriesExhaustedException that wraps the actual thrown exception and presents it clearly as a retry issue. This will be very helpful, I think. Perhaps the exception can even take a list of the exceptions that led up to this point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-603) When an exception bubbles out of getRegionServerWithRetries, wrap the exception with a RetriesExhaustedException

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HBASE-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated HBASE-603:
--------------------------------

    Attachment: 603.patch

Here's a patch for this. Passes unit tests, though TTI was giving me a little trouble. Don't know if it's related or not.

> When an exception bubbles out of getRegionServerWithRetries, wrap the exception with a RetriesExhaustedException
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-603
>                 URL: https://issues.apache.org/jira/browse/HBASE-603
>             Project: Hadoop HBase
>          Issue Type: New Feature
>          Components: client
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: 603.patch
>
>
> There's always a lot of confusion about what NotServingRegionExceptions and WrongRegionExceptions mean when they come out of the client side. To help alleviate this, I propose that we create a new exception type called RetriesExhaustedException that wraps the actual thrown exception and presents it clearly as a retry issue. This will be very helpful, I think. Perhaps the exception can even take a list of the exceptions that led up to this point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-603) When an exception bubbles out of getRegionServerWithRetries, wrap the exception with a RetriesExhaustedException

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HBASE-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated HBASE-603:
--------------------------------

    Status: Patch Available  (was: Open)

Please review.

> When an exception bubbles out of getRegionServerWithRetries, wrap the exception with a RetriesExhaustedException
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-603
>                 URL: https://issues.apache.org/jira/browse/HBASE-603
>             Project: Hadoop HBase
>          Issue Type: New Feature
>          Components: client
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: 603.patch
>
>
> There's always a lot of confusion about what NotServingRegionExceptions and WrongRegionExceptions mean when they come out of the client side. To help alleviate this, I propose that we create a new exception type called RetriesExhaustedException that wraps the actual thrown exception and presents it clearly as a retry issue. This will be very helpful, I think. Perhaps the exception can even take a list of the exceptions that led up to this point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-603) When an exception bubbles out of getRegionServerWithRetries, wrap the exception with a RetriesExhaustedException

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HBASE-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated HBASE-603:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I fixed the javadoc like Jim suggestion. Committed to trunk.

> When an exception bubbles out of getRegionServerWithRetries, wrap the exception with a RetriesExhaustedException
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-603
>                 URL: https://issues.apache.org/jira/browse/HBASE-603
>             Project: Hadoop HBase
>          Issue Type: New Feature
>          Components: client
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: 603.patch
>
>
> There's always a lot of confusion about what NotServingRegionExceptions and WrongRegionExceptions mean when they come out of the client side. To help alleviate this, I propose that we create a new exception type called RetriesExhaustedException that wraps the actual thrown exception and presents it clearly as a retry issue. This will be very helpful, I think. Perhaps the exception can even take a list of the exceptions that led up to this point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (HBASE-603) When an exception bubbles out of getRegionServerWithRetries, wrap the exception with a RetriesExhaustedException

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HBASE-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury reassigned HBASE-603:
-----------------------------------

    Assignee: Bryan Duxbury

> When an exception bubbles out of getRegionServerWithRetries, wrap the exception with a RetriesExhaustedException
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-603
>                 URL: https://issues.apache.org/jira/browse/HBASE-603
>             Project: Hadoop HBase
>          Issue Type: New Feature
>          Components: client
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>             Fix For: 0.2.0
>
>
> There's always a lot of confusion about what NotServingRegionExceptions and WrongRegionExceptions mean when they come out of the client side. To help alleviate this, I propose that we create a new exception type called RetriesExhaustedException that wraps the actual thrown exception and presents it clearly as a retry issue. This will be very helpful, I think. Perhaps the exception can even take a list of the exceptions that led up to this point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-603) When an exception bubbles out of getRegionServerWithRetries, wrap the exception with a RetriesExhaustedException

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HBASE-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593151#action_12593151 ] 

Jim Kellerman commented on HBASE-603:
-------------------------------------

RetriesExhaustedException : javadoc incorrect for constructor

otherwise +1

> When an exception bubbles out of getRegionServerWithRetries, wrap the exception with a RetriesExhaustedException
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-603
>                 URL: https://issues.apache.org/jira/browse/HBASE-603
>             Project: Hadoop HBase
>          Issue Type: New Feature
>          Components: client
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: 603.patch
>
>
> There's always a lot of confusion about what NotServingRegionExceptions and WrongRegionExceptions mean when they come out of the client side. To help alleviate this, I propose that we create a new exception type called RetriesExhaustedException that wraps the actual thrown exception and presents it clearly as a retry issue. This will be very helpful, I think. Perhaps the exception can even take a list of the exceptions that led up to this point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.