You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by gi...@git.apache.org on 2017/09/14 14:57:47 UTC

[GitHub] eiri opened a new pull request #817: Don't crash on invalid inline attachments

eiri opened a new pull request #817: Don't crash on invalid inline attachments
URL: https://github.com/apache/couchdb/pull/817
 
 
   ## Overview
   
   We trust inline attachment to be base64 encoded, so in case it's not provided or invalidly encoded the upload request crashes with `function_clause`.
   
   The change catches decode attempt and re-throws it as 400 error.
   
   ## Testing recommendations
   
   Standard eunit and javascript tests should pass.
   
   ## GitHub issue number
   
   Fixes #784 
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services