You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by shivaram <gi...@git.apache.org> on 2018/05/13 22:25:47 UTC

[GitHub] spark pull request #21314: [SPARK-24263][R] SparkR java check breaks with op...

Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21314#discussion_r187815145
  
    --- Diff: R/pkg/R/client.R ---
    @@ -82,7 +82,7 @@ checkJavaVersion <- function() {
                        })
       javaVersionFilter <- Filter(
           function(x) {
    -        grepl("java version", x)
    +        grepl(" version", x)
    --- End diff --
    
    do we want the space " version" vs. "version" that is


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org