You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by lapo-luchini <gi...@git.apache.org> on 2014/07/18 16:42:12 UTC

[GitHub] cordova-ios pull request: Fix __PROECT_NAME__ replacing code

GitHub user lapo-luchini opened a pull request:

    https://github.com/apache/cordova-ios/pull/100

    Fix __PROECT_NAME__ replacing code

    `&` is a special character for `sed` and this fixes the problem of having `__PROJECT_NAME__` in the final output when the project name contains an ampersand, this is not only a cosmetic issue but also leads to compilation errors:
    
        xcodebuild: error: The project 'A&B.xcodeproj' does not contain a target named 'A&B'.
        { [Error: /Users/lapo/projDir/platforms/ios/cordova/build: Command failed with exit code 65] code: 65 }
           [error] /Users/lapo/projDir/platforms/ios/cordova/build: Command failed with exit code 65

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lapo-luchini/cordova-ios master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #100
    
----
commit f1fdb5145ea923229b2a2aec68c32d464575577c
Author: Lapo Luchini <la...@lapo.it>
Date:   2014-07-18T14:38:10Z

    Fix __PROECT_NAME__ replacing code
    
    `&` is a special character for `sed` and this fixes the problem of having `__PROJECT_NAME__` in the final output when the project name contains an ampersand.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-ios pull request: Fix __PROJECT_NAME__ replacing code

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-ios/pull/100


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-ios pull request: Fix __PROJECT_NAME__ replacing code

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-ios/pull/100#issuecomment-49486359
  
    Created [CB-7169](https://issues.apache.org/jira/browse/CB-7169)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---