You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/30 16:53:51 UTC
[GitHub] [superset] codecov[bot] commented on pull request #13868: fix: change status code for generic errors to 422
codecov[bot] commented on pull request #13868:
URL: https://github.com/apache/superset/pull/13868#issuecomment-810420000
# [Codecov](https://codecov.io/gh/apache/superset/pull/13868?src=pr&el=h1) Report
> Merging [#13868](https://codecov.io/gh/apache/superset/pull/13868?src=pr&el=desc) (73aa8c1) into [master](https://codecov.io/gh/apache/superset/commit/467848d8f7edd5387ead2f02a7d54bda7523cf7d?el=desc) (467848d) will **decrease** coverage by `0.29%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13868?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13868 +/- ##
==========================================
- Coverage 75.56% 75.27% -0.30%
==========================================
Files 935 935
Lines 47275 47247 -28
Branches 5883 5883
==========================================
- Hits 35725 35565 -160
- Misses 11375 11507 +132
Partials 175 175
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.60% <100.00%> (ø)` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.60% <100.00%> (-0.55%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13868?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.61% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `89.53% <0.00%> (-6.98%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/superset/pull/13868/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13868?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13868?src=pr&el=footer). Last update [467848d...73aa8c1](https://codecov.io/gh/apache/superset/pull/13868?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org