[jira] [Commented] (STREAMS-243) S3 Persist Writer does not flush or shutdown on stream shutdown

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STREAMS-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390735#comment-14390735 ] 

ASF GitHub Bot commented on STREAMS-243:
----------------------------------------

Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/167#discussion_r27576783
  
    --- Diff: streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/java/org/apache/streams/s3/S3Configurator.java ---
    @@ -64,15 +64,15 @@ public static S3WriterConfiguration detectWriterConfiguration(Config s3) {
     
             try {
                 s3Configuration = mapper.readValue(s3.root().render(ConfigRenderOptions.concise()), S3WriterConfiguration.class);
    +
    +            if(!s3Configuration.getWriterPath().endsWith("/")) {
    +                s3Configuration.setWriterPath(s3Configuration.getWriterPath() + "/");
    +            }
             } catch (Exception e) {
                 e.printStackTrace();
    --- End diff --
    
    done.


> S3 Persist Writer does not flush or shutdown on stream shutdown
> ---------------------------------------------------------------
>
>                 Key: STREAMS-243
>                 URL: https://issues.apache.org/jira/browse/STREAMS-243
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Steve Blackmon
>             Fix For: 0.2
>
>
> S3 Persist Writer does not seem to flush or shutdown on stream shutdown, which has the side-effect of not allowing the stream process to close.
> When cleanUp() is called, the writer should flush and terminate gracefully.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)