You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2017/12/13 00:24:18 UTC

[GitHub] merlimat commented on a change in pull request #961: Issue 922: allow run bookie together with broker

merlimat commented on a change in pull request #961: Issue 922: allow run bookie together with broker
URL: https://github.com/apache/incubator-pulsar/pull/961#discussion_r156532369
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarBrokerStarter.java
 ##########
 @@ -44,8 +55,79 @@ private static ServiceConfiguration loadConfig(String configFile) throws Excepti
         return config;
     }
 
+    private static final Options OPTS = new Options();
 
 Review comment:
   We use JCommander for parsing CLI options in the other tools, eg: see https://github.com/apache/incubator-pulsar/blob/45ea0bc45e67751711708ecd7ba8f446ff34c67a/pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java#L52

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services