You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by tr...@apache.org on 2007/07/26 09:06:18 UTC

svn commit: r559725 - in /mina: branches/1.0/core/src/main/java/org/apache/mina/filter/codec/ branches/1.1/core/src/main/java/org/apache/mina/filter/codec/ trunk/core/src/main/java/org/apache/mina/filter/codec/

Author: trustin
Date: Thu Jul 26 00:06:17 2007
New Revision: 559725

URL: http://svn.apache.org/viewvc?view=rev&rev=559725
Log:
Fixed issue: DIRMINA-406 (ProtocolDecoder.dispose() is called for every read.)
* Removed unnecessary call to ProtocolDecoder.dispose() in ProtocolCodecFilter


Modified:
    mina/branches/1.0/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java
    mina/branches/1.1/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java
    mina/trunk/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java

Modified: mina/branches/1.0/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java
URL: http://svn.apache.org/viewvc/mina/branches/1.0/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java?view=diff&rev=559725&r1=559724&r2=559725
==============================================================================
--- mina/branches/1.0/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java (original)
+++ mina/branches/1.0/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java Thu Jul 26 00:06:17 2007
@@ -162,11 +162,6 @@
             pde.setHexdump(in.getHexDump());
             throw pde;
         } finally {
-            // Dispose the decoder if this session is connectionless.
-            if (session.getTransportType().isConnectionless()) {
-                disposeDecoder(session);
-            }
-
             // Release the read buffer.
             in.release();
 

Modified: mina/branches/1.1/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java
URL: http://svn.apache.org/viewvc/mina/branches/1.1/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java?view=diff&rev=559725&r1=559724&r2=559725
==============================================================================
--- mina/branches/1.1/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java (original)
+++ mina/branches/1.1/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java Thu Jul 26 00:06:17 2007
@@ -165,11 +165,6 @@
             pde.setHexdump(in.getHexDump());
             throw pde;
         } finally {
-            // Dispose the decoder if this session is connectionless.
-            if (session.getTransportType().isConnectionless()) {
-                disposeDecoder(session);
-            }
-
             // Release the read buffer.
             in.release();
 

Modified: mina/trunk/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java?view=diff&rev=559725&r1=559724&r2=559725
==============================================================================
--- mina/trunk/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java (original)
+++ mina/trunk/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java Thu Jul 26 00:06:17 2007
@@ -170,11 +170,6 @@
             pde.setHexdump(in.getHexDump());
             throw pde;
         } finally {
-            // Dispose the decoder if this session is connectionless.
-            if (session.getTransportType().isConnectionless()) {
-                disposeDecoder(session);
-            }
-
             decoderOut.flush();
         }
     }