You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/22 14:59:24 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #14450: ARROW-15822: [C++] Cast duration to string (thus CSV writing) not supported

pitrou commented on code in PR #14450:
URL: https://github.com/apache/arrow/pull/14450#discussion_r1002501635


##########
cpp/src/arrow/type.cc:
##########
@@ -2462,6 +2462,10 @@ void InitStaticData() {
   // Temporal types
   g_temporal_types = {date32(),
                       date64(),
+                      duration(TimeUnit::SECOND),
+                      duration(TimeUnit::MILLI),
+                      duration(TimeUnit::MICRO),
+                      duration(TimeUnit::NANO),

Review Comment:
   I'm not sure that's right. Given that we have a separate category here for interval types, it probably means we also want a dedicated category for durations?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org