You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "vjuranek (via GitHub)" <gi...@apache.org> on 2023/02/14 13:48:05 UTC
[GitHub] [camel] vjuranek opened a new pull request, #9348: [CAMEL-18610] Upgrade to Debezium 2.X
vjuranek opened a new pull request, #9348:
URL: https://github.com/apache/camel/pull/9348
# Description
Upgrade Debezium maven plugin and all Debezium connectors to Debezium 2.X. Debezium 2.0 introduced backward incompatible changes and therefore current connectors cannot work with Debezium 2.X. Which is also the reason why the changes should to Camel 4.0, to keep compatibility in 3.X branch.
# Target
- [x ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
https://issues.apache.org/jira/browse/CAMEL-18610
# Apache Camel coding standards and style
- [x ] I checked that each commit in the pull request has a meaningful subject line and body.
- [ x] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vjuranek commented on a diff in pull request #9348: [CAMEL-18610] Upgrade to Debezium 2.X
Posted by "vjuranek (via GitHub)" <gi...@apache.org>.
vjuranek commented on code in PR #9348:
URL: https://github.com/apache/camel/pull/9348#discussion_r1106128884
##########
components/camel-debezium/camel-debezium-common/camel-debezium-common-component/pom.xml:
##########
@@ -41,7 +41,7 @@
<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
- <version>3.0.2</version>
+ <version>3.3.2</version>
Review Comment:
thanks, checking it more carefully, 2.1.2.Final is actually based on [kafka 3.3.1](https://github.com/debezium/debezium/blob/v2.1.2.Final/pom.xml#L96) (we recently upgraded to 3.4.0, but it will be in 2.2.0 which is not released yet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #9348: [CAMEL-18610] Upgrade to Debezium 2.X
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #9348:
URL: https://github.com/apache/camel/pull/9348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9348: [CAMEL-18610] Upgrade to Debezium 2.X
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9348:
URL: https://github.com/apache/camel/pull/9348#issuecomment-1430182177
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a diff in pull request #9348: [CAMEL-18610] Upgrade to Debezium 2.X
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on code in PR #9348:
URL: https://github.com/apache/camel/pull/9348#discussion_r1105952839
##########
components/camel-debezium/camel-debezium-common/camel-debezium-common-component/pom.xml:
##########
@@ -41,7 +41,7 @@
<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
- <version>3.0.2</version>
+ <version>3.3.2</version>
Review Comment:
Is it based on Kafka 3.3.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9348: [CAMEL-18610] Upgrade to Debezium 2.X
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9348:
URL: https://github.com/apache/camel/pull/9348#issuecomment-1430951181
Yeah I have fixed the CS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9348: [CAMEL-18610] Upgrade to Debezium 2.X
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9348:
URL: https://github.com/apache/camel/pull/9348#issuecomment-1429775118
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vjuranek commented on pull request #9348: [CAMEL-18610] Upgrade to Debezium 2.X
Posted by "vjuranek (via GitHub)" <gi...@apache.org>.
vjuranek commented on PR #9348:
URL: https://github.com/apache/camel/pull/9348#issuecomment-1430949000
Checkstyle failure is not related to this PR, it fails in `camel-jbang-core`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vjuranek commented on a diff in pull request #9348: [CAMEL-18610] Upgrade to Debezium 2.X
Posted by "vjuranek (via GitHub)" <gi...@apache.org>.
vjuranek commented on code in PR #9348:
URL: https://github.com/apache/camel/pull/9348#discussion_r1106128884
##########
components/camel-debezium/camel-debezium-common/camel-debezium-common-component/pom.xml:
##########
@@ -41,7 +41,7 @@
<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
- <version>3.0.2</version>
+ <version>3.3.2</version>
Review Comment:
thanks, checking it more carefully, 2.1.2.Final is actually based on [kafka 3.3.1](https://github.com/debezium/debezium/blob/v2.1.2.Final/pom.xml#L96) (we recently upgraded to 3.4.0, but it will be in 2.2.0 which is not released yet) - fixed to 3.3.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9348: [CAMEL-18610] Upgrade to Debezium 2.X
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9348:
URL: https://github.com/apache/camel/pull/9348#issuecomment-1429862536
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org