[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #6271: Combine the two rules: DecorrelateWhereExists and DecorrelateWhereIn

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener commented on code in PR #6271:
URL: https://github.com/apache/arrow-datafusion/pull/6271#discussion_r1191907790


##########
datafusion/optimizer/src/decorrelate_predicate_subquery.rs:
##########
@@ -54,7 +59,7 @@ impl DecorrelateWhereIn {
         predicate: &Expr,
         config: &dyn OptimizerConfig,
     ) -> Result<(Vec<SubqueryInfo>, Vec<Expr>)> {
-        let filters = split_conjunction(predicate); // TODO: disjunctions
+        let filters = split_conjunction(predicate); // TODO: add ExistenceJoin to support disjunctions

Review Comment:
   This PR already support disjunction of scalar/in subquery?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org