You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Felix Meschberger <fm...@gmail.com> on 2010/09/20 08:21:32 UTC

Launchpad port consistency

Hi all,

We currently have an inconsistency in the setup of the jetty:run
configuration in the the launchpad/builder module and the default port
used by the Sling standalone application.

The jetty plugin is configured to use port 8888 by default, while the
standalone application by default uses port 8080. In addition the
integration tests in the launchpad/integration-tests module also assume
a default of port 8888.

I think we should consolidate on a single port number.

Since most configuration uses 8888 by default, the easiest would
probably be to change the standalone app default to 8888.

WDYT ?

Regards
Felix

Re: Launchpad port consistency

Posted by Ian Boston <ie...@tfd.co.uk>.
On 21 Sep 2010, at 00:16, Carsten Ziegeler wrote:

> Bertrand Delacretaz  wrote
>> On Mon, Sep 20, 2010 at 11:01 AM, Felix Meschberger <fm...@gmail.com> wrote:
>>> ...IIUIC the launchpad/testing module uses a build-helper plugin to use a
>>> random port for integration testing....
>> 
>> That's correct.
>> 
>> Apart from that, I agree with Felix about having a consistent port
>> number, don't care much about 8080 or 8888.
>> 
> Once I was used to 8888, now I'm used to 8080 due to the sling launchpad
> app, so I would prefer 8080 :)
> But in the end it doesn't matter that much to me as long as it is
> consistent.

Agreed, 
a consistent port number is the key thing.
I realise having spent formative years with Tomcat I a more used to 8080, had those formative years been with Jetty it would have 8888. 

If others are Ok with 8080, then that would be great (for me) and reduce the number of questions from newbees in the Sakai community converting from Tomcat.

Thanks
Ian


> 
> Carsten
> -- 
> Carsten Ziegeler
> cziegeler@apache.org


Re: Launchpad port consistency

Posted by Carsten Ziegeler <cz...@apache.org>.
Bertrand Delacretaz  wrote
> On Mon, Sep 20, 2010 at 11:01 AM, Felix Meschberger <fm...@gmail.com> wrote:
>> ...IIUIC the launchpad/testing module uses a build-helper plugin to use a
>> random port for integration testing....
> 
> That's correct.
> 
> Apart from that, I agree with Felix about having a consistent port
> number, don't care much about 8080 or 8888.
> 
Once I was used to 8888, now I'm used to 8080 due to the sling launchpad
app, so I would prefer 8080 :)
But in the end it doesn't matter that much to me as long as it is
consistent.

Carsten
-- 
Carsten Ziegeler
cziegeler@apache.org

Re: Launchpad port consistency

Posted by Bertrand Delacretaz <bd...@apache.org>.
On Mon, Sep 20, 2010 at 11:01 AM, Felix Meschberger <fm...@gmail.com> wrote:
> ...IIUIC the launchpad/testing module uses a build-helper plugin to use a
> random port for integration testing....

That's correct.

Apart from that, I agree with Felix about having a consistent port
number, don't care much about 8080 or 8888.

-Bertrand

Re: Launchpad port consistency

Posted by Felix Meschberger <fm...@gmail.com>.
Hi,

Am 20.09.2010 10:29, schrieb Ian Boston:
> 
> On 20 Sep 2010, at 16:21, Felix Meschberger wrote:
> 
>> Hi all,
>>
>> We currently have an inconsistency in the setup of the jetty:run
>> configuration in the the launchpad/builder module and the default port
>> used by the Sling standalone application.
>>
>> The jetty plugin is configured to use port 8888 by default, while the
>> standalone application by default uses port 8080. In addition the
>> integration tests in the launchpad/integration-tests module also assume
>> a default of port 8888.
>>
>> I think we should consolidate on a single port number.
>>
>> Since most configuration uses 8888 by default, the easiest would
>> probably be to change the standalone app default to 8888.
>>
>> WDYT ?
> 
> 
> I am not certain this is a good idea. At the moment you can run an app, and do another build at the same time without touching the config or adding a -p on the command line. Having the test run on 8888 is good in that respect.
> 
> Most people expect java http apps to appear on 8080. Having to communicate to a wider community that they need to add -p 8080 or stop going to 8080 and now go to 8888 is going to generate list traffic of confused downstream users.

Ok, then how about changing the default setup of the jetty plugin to
port 8080 and setting the default URL for the integration tests to use
port 8080, too.

IIUIC the launchpad/testing module uses a build-helper plugin to use a
random port for integration testing.

Regards
Felix

> 
> Ian
> 
>>
>> Regards
>> Felix
> 
> 

Re: Launchpad port consistency

Posted by Ian Boston <ie...@tfd.co.uk>.
On 20 Sep 2010, at 16:21, Felix Meschberger wrote:

> Hi all,
> 
> We currently have an inconsistency in the setup of the jetty:run
> configuration in the the launchpad/builder module and the default port
> used by the Sling standalone application.
> 
> The jetty plugin is configured to use port 8888 by default, while the
> standalone application by default uses port 8080. In addition the
> integration tests in the launchpad/integration-tests module also assume
> a default of port 8888.
> 
> I think we should consolidate on a single port number.
> 
> Since most configuration uses 8888 by default, the easiest would
> probably be to change the standalone app default to 8888.
> 
> WDYT ?


I am not certain this is a good idea. At the moment you can run an app, and do another build at the same time without touching the config or adding a -p on the command line. Having the test run on 8888 is good in that respect.

Most people expect java http apps to appear on 8080. Having to communicate to a wider community that they need to add -p 8080 or stop going to 8080 and now go to 8888 is going to generate list traffic of confused downstream users.

Ian

> 
> Regards
> Felix