You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2019/02/20 19:36:00 UTC

[GitHub] xiaoyao1991 commented on a change in pull request #3195: 2D(RAM, CPU) Vector Binpacking (FirstFit Decreasing) Packing

xiaoyao1991 commented on a change in pull request #3195: 2D(RAM, CPU) Vector Binpacking (FirstFit Decreasing) Packing
URL: https://github.com/apache/incubator-heron/pull/3195#discussion_r258643638
 
 

 ##########
 File path: heron/packing/src/java/org/apache/heron/packing/binpacking/TwoDimensionVectorBinPacking.java
 ##########
 @@ -0,0 +1,379 @@
+/**
 
 Review comment:
   That actually sounds perfect to me. I prefer not to have too many packing classes too. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services