You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sdedic (via GitHub)" <gi...@apache.org> on 2023/08/15 15:16:38 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #6344: Maven Embedder resolve() fix
sdedic opened a new pull request, #6344:
URL: https://github.com/apache/netbeans/pull/6344
This is a followup to #6197 which was partially reverted by #6228 before the release. This PR adds a few bruises (such as properly configuring the Resolver with remote repositories).
It deprecates the old `resolve()` method in favour of new `resolveArtifact`, which should ensure backwards (although faulty) compatibilty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #6344: Maven Embedder resolve() fix
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic merged PR #6344:
URL: https://github.com/apache/netbeans/pull/6344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #6344: Maven Embedder resolve() fix
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #6344:
URL: https://github.com/apache/netbeans/pull/6344#discussion_r1295271172
##########
java/maven.embedder/src/org/netbeans/modules/maven/embedder/MavenEmbedder.java:
##########
@@ -367,6 +373,7 @@ public ArtifactRepository createRemoteRepository(String url, String id) {
* @param localRepository
* @throws ArtifactResolutionException
* @throws ArtifactNotFoundException
+ * @deprecated the Maven API used swallows certain {@link ArtifactNotFoundException} and does not report properly to the caller. Use {@link #resolveArtifact} instead.
*/
public void resolve(Artifact sources, List<ArtifactRepository> remoteRepositories, ArtifactRepository localRepository) throws ArtifactResolutionException, ArtifactNotFoundException {
Review Comment:
please add the` @Deprecated` annotation too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists