[GitHub] [beam] robertwb commented on a change in pull request #10951: [BEAM-8575] Modified the test to work for different runners.

[GitBox <gi...@apache.org>]

robertwb commented on a change in pull request #10951: [BEAM-8575] Modified the test to work for different runners.
URL: https://github.com/apache/beam/pull/10951#discussion_r387210573
 
 

 ##########
 File path: sdks/python/apache_beam/transforms/combiners_test.py
 ##########
 @@ -482,9 +492,20 @@ def test_combining_with_accumulation_mode_and_fanout(self):
               trigger=AfterWatermark(early=AfterAll(AfterCount(1))))
           | beam.CombineGlobally(sum).without_defaults().with_fanout(2))
 
-      # The frings for DISCARDING mode is [1, 2, 3, 4, 5, 0, 0].
-      firings = [1, 3, 6, 10, 15, 15, 15]
-      assert_that(result, equal_to(firings))
+      # Partition the result into early_firings and _.
+      # In ACCUMULATING mode, the early_frings is [1, 3, 6, 10],
+      # other_firings is [15, 15, ...]. Different runners have different
+      # number of 15s, but there should be at least one 15.
+      smaller_than_fifteen, fifteen, greater_than_fifteen = (
 
 Review comment:
   Rather than do a partition, I would write something like
   
   ```
   def has_expected_values(actual):
     ordered = sorted(actual)
     # Early firings.
     hamcrest.assert_that(ordered[:4], hamcrest.contains(1, 3, 6, 10))
     # Different runners have different number of 15s, but there should be at least one 15.
     hamcrest.assert_that(set(ordered[4:]), hamcrest.contains(15))
   assert_that(result, has_expected_values)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services