You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by andyetitmoves <gi...@git.apache.org> on 2014/12/30 20:47:47 UTC
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
GitHub user andyetitmoves opened a pull request:
https://github.com/apache/lucene-solr/pull/121
Use JUnit rules instead of inheritance with distributed Solr tests to allow for multiple tests without the same class
Patch for SOLR-6902
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bloomberg/lucene-solr trunk-shard-junit-rule
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit 02d678044a9f399a6bdf63e9a977d6e760a0a1bf
Author: Ramkumar Aiyengar <ra...@bloomberg.net>
Date: 2014-12-30T14:39:23Z
Use JUnit rules instead of inheritance with distributed tests to allow for multiple tests without the same class.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22384210
--- Diff: solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java ---
@@ -861,23 +877,107 @@ protected void compareResponses(QueryResponse a, QueryResponse b) {
compareSolrResponses(a, b);
}
- @Test
- public void testDistribSearch() throws Exception {
- if (fixShardCount) {
- createServers(shardCount);
- RandVal.uniqueValues = new HashSet(); //reset random values
- doTest();
- destroyServers();
- } else {
- for (int nServers = 1; nServers < shardCount; nServers++) {
- createServers(nServers);
+ @Retention(RetentionPolicy.RUNTIME)
+ @Target(ElementType.METHOD)
+ public @interface ShardsRepeat {
+ public abstract int min() default 1;
+ public abstract int max() default DEFAULT_MAX_SHARD_COUNT;
+ }
+
+ @Retention(RetentionPolicy.RUNTIME)
+ @Target(ElementType.METHOD)
+ public @interface ShardsFixed {
+ public abstract int num();
+ }
+
+ public class ShardsRepeatRule implements TestRule {
+
+ private abstract class ShardsStatement extends Statement {
+ abstract protected void callStatement() throws Throwable;
+
+ @Override
+ public void evaluate() throws Throwable {
+ distribSetUp();
--- End diff --
If the goal is to force sub classes to call distribSetUp() then maybe a better pattern would be something like http://stackoverflow.com/a/4217174/370585. It's technically ansswering an unrelated question, but I think it still applies to our case here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by andyetitmoves <gi...@git.apache.org>.
Github user andyetitmoves commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22386755
--- Diff: solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java ---
@@ -861,23 +877,107 @@ protected void compareResponses(QueryResponse a, QueryResponse b) {
compareSolrResponses(a, b);
}
- @Test
- public void testDistribSearch() throws Exception {
- if (fixShardCount) {
- createServers(shardCount);
- RandVal.uniqueValues = new HashSet(); //reset random values
- doTest();
- destroyServers();
- } else {
- for (int nServers = 1; nServers < shardCount; nServers++) {
- createServers(nServers);
+ @Retention(RetentionPolicy.RUNTIME)
+ @Target(ElementType.METHOD)
+ public @interface ShardsRepeat {
+ public abstract int min() default 1;
+ public abstract int max() default DEFAULT_MAX_SHARD_COUNT;
+ }
+
+ @Retention(RetentionPolicy.RUNTIME)
+ @Target(ElementType.METHOD)
+ public @interface ShardsFixed {
+ public abstract int num();
+ }
+
+ public class ShardsRepeatRule implements TestRule {
+
+ private abstract class ShardsStatement extends Statement {
+ abstract protected void callStatement() throws Throwable;
+
+ @Override
+ public void evaluate() throws Throwable {
+ distribSetUp();
--- End diff --
No, {{distribSetUp}} is actually optional, quite a few sub-classes don't call it..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362769
--- Diff: solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java ---
@@ -861,23 +869,107 @@ protected void compareResponses(QueryResponse a, QueryResponse b) {
compareSolrResponses(a, b);
}
- @Test
- public void testDistribSearch() throws Exception {
- if (fixShardCount) {
- createServers(shardCount);
- RandVal.uniqueValues = new HashSet(); //reset random values
- doTest();
- destroyServers();
- } else {
- for (int nServers = 1; nServers < shardCount; nServers++) {
- createServers(nServers);
+ @Retention(RetentionPolicy.RUNTIME)
+ @Target(ElementType.METHOD)
+ public @interface ShardsRepeat {
+ public abstract int min() default 1;
+ public abstract int max() default DEFAULT_MAX_SHARD_COUNT;
+ }
+
+ @Retention(RetentionPolicy.RUNTIME)
+ @Target(ElementType.METHOD)
+ public @interface ShardsFixed {
+ public abstract int num();
+ }
+
+ public class ShardsRepeatRule implements TestRule {
--- End diff --
+1 This is a really good idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22387405
--- Diff: solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java ---
@@ -861,23 +877,107 @@ protected void compareResponses(QueryResponse a, QueryResponse b) {
compareSolrResponses(a, b);
}
- @Test
- public void testDistribSearch() throws Exception {
- if (fixShardCount) {
- createServers(shardCount);
- RandVal.uniqueValues = new HashSet(); //reset random values
- doTest();
- destroyServers();
- } else {
- for (int nServers = 1; nServers < shardCount; nServers++) {
- createServers(nServers);
+ @Retention(RetentionPolicy.RUNTIME)
+ @Target(ElementType.METHOD)
+ public @interface ShardsRepeat {
+ public abstract int min() default 1;
+ public abstract int max() default DEFAULT_MAX_SHARD_COUNT;
+ }
+
+ @Retention(RetentionPolicy.RUNTIME)
+ @Target(ElementType.METHOD)
+ public @interface ShardsFixed {
+ public abstract int num();
+ }
+
+ public class ShardsRepeatRule implements TestRule {
+
+ private abstract class ShardsStatement extends Statement {
+ abstract protected void callStatement() throws Throwable;
+
+ @Override
+ public void evaluate() throws Throwable {
+ distribSetUp();
--- End diff --
Worth noting that if distribSetUp() fials for some reason then distribTearDown() will not be called. See https://github.com/junit-team/junit/blob/master/src/main/java/org/junit/rules/ExternalResource.java for this same pattern.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362519
--- Diff: solr/core/src/test/org/apache/solr/cloud/TriLevelCompositeIdRoutingTest.java ---
@@ -155,8 +153,8 @@ private String getKey(String id) {
}
@Override
- public void tearDown() throws Exception {
- super.tearDown();
+ public void distribTearDown() throws Exception {
--- End diff --
Is this override necessary? Without it, the call would just resolve to the super class anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by andyetitmoves <gi...@git.apache.org>.
Github user andyetitmoves commented on the pull request:
https://github.com/apache/lucene-solr/pull/121#issuecomment-68452527
Currently `ShardsFixed` has to be a per-test-method annotation, I would personally prefer if each test took that decision independently (of how it's shard setup should look..)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362409
--- Diff: solr/core/src/test/org/apache/solr/cloud/DeleteShardTest.java ---
@@ -71,7 +68,7 @@ public void tearDown() throws Exception {
if (controlClientCloud != null) {
controlClientCloud.shutdown();
}
- super.tearDown();
+ super.distribTearDown();
--- End diff --
super.distribTearDown() is called twice in this method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362862
--- Diff: solr/core/src/test/org/apache/solr/update/SolrCmdDistributorTest.java ---
@@ -506,14 +506,14 @@ public boolean checkRetry() {
}
@Override
- public void setUp() throws Exception {
- super.setUp();
+ public void distribSetUp() throws Exception {
--- End diff --
There's a couple of these "no-op" distribSetup() calls too; if we remove the distribTearDown() ones, then these should go too. Leaving them in is probably fine though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #121: [SOLR-9817] Make "working directory" for Solr...
Posted by hgadre <gi...@git.apache.org>.
Github user hgadre closed the pull request at:
https://github.com/apache/lucene-solr/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #121: [SOLR-9817] Make "working directory" for Solr server...
Posted by hgadre <gi...@git.apache.org>.
Github user hgadre commented on the issue:
https://github.com/apache/lucene-solr/pull/121
@markrmiller can you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by andyetitmoves <gi...@git.apache.org>.
Github user andyetitmoves commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22386987
--- Diff: solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java ---
@@ -861,23 +877,107 @@ protected void compareResponses(QueryResponse a, QueryResponse b) {
compareSolrResponses(a, b);
}
- @Test
- public void testDistribSearch() throws Exception {
- if (fixShardCount) {
- createServers(shardCount);
- RandVal.uniqueValues = new HashSet(); //reset random values
- doTest();
- destroyServers();
- } else {
- for (int nServers = 1; nServers < shardCount; nServers++) {
- createServers(nServers);
+ @Retention(RetentionPolicy.RUNTIME)
+ @Target(ElementType.METHOD)
+ public @interface ShardsRepeat {
+ public abstract int min() default 1;
+ public abstract int max() default DEFAULT_MAX_SHARD_COUNT;
+ }
+
+ @Retention(RetentionPolicy.RUNTIME)
+ @Target(ElementType.METHOD)
+ public @interface ShardsFixed {
+ public abstract int num();
+ }
+
+ public class ShardsRepeatRule implements TestRule {
+
+ private abstract class ShardsStatement extends Statement {
+ abstract protected void callStatement() throws Throwable;
+
+ @Override
+ public void evaluate() throws Throwable {
+ distribSetUp();
--- End diff --
To some extent I guess, what this does though is in most cases ensures the entire chain is called (and not just this {{distribSetUp}}), and there are quite a few abstract sub-classes for this which would want them to be called as well. There are ways to subvert that still, but at least this protects against a simple {{super.distribSetUp()}} not being called..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362512
--- Diff: solr/core/src/test/org/apache/solr/cloud/TestDistribDocBasedVersion.java ---
@@ -350,8 +348,8 @@ void doDBQ(String q, String... reqParams) throws Exception {
}
@Override
- public void tearDown() throws Exception {
- super.tearDown();
+ public void distribTearDown() throws Exception {
--- End diff --
Is this override necessary? Without it, the call would just resolve to the super class anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22384247
--- Diff: solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java ---
@@ -269,20 +285,20 @@ public Object val() {
public String getSolrHome() {
return SolrTestCaseJ4.TEST_HOME();
}
-
- @Override
- public void setUp() throws Exception {
+
+ private boolean distribSetUpCalled = false;
+ public void distribSetUp() throws Exception {
--- End diff --
I think I'm being dense here, but why do we call this manually from the Rule instead of letting Before handle it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362948
--- Diff: solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java ---
@@ -173,16 +179,25 @@ protected BaseDistributedSearchTestCase(final String context) {
"[ff01::213]:33332" + context};
}
- protected int shardCount = 4; // the actual number of solr cores that will be created in the cluster
+ private final static int DEFAULT_MAX_SHARD_COUNT = 3;
+
+ private int shardCount = -1; // the actual number of solr cores that will be created in the cluster
+ public int getShardCount() {
+ return shardCount;
+ }
+
+ private boolean isShardCountFixed = false;
/**
- * Sub classes can set this flag in their constructor to true if they
- * want to fix the number of shards to 'shardCount'
+ * Sub classes can call this in their constructor to fix the number of shards
*
- * The default is false which means that test will be executed with
- * 1, 2, 3, ....shardCount number of shards repeatedly
+ * By default, the test will be executed with
+ * 1, 2, ... DEFAULT_MAX_SHARD_COUNT number of shards repeatedly
*/
- protected boolean fixShardCount = false;
+ public void fixShardCount(int count) {
--- End diff --
Maybe add a reference to the annotations and explain why one is preferred over the other for the benefit of future test writers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by andyetitmoves <gi...@git.apache.org>.
Github user andyetitmoves commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22387051
--- Diff: solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java ---
@@ -269,20 +285,20 @@ public Object val() {
public String getSolrHome() {
return SolrTestCaseJ4.TEST_HOME();
}
-
- @Override
- public void setUp() throws Exception {
+
+ private boolean distribSetUpCalled = false;
+ public void distribSetUp() throws Exception {
--- End diff --
Couldn't figure out a way to have the rule run after `Before` (`Rule`s seem to be always called before `Before`), which is what is needed here, as the rule makes use of what's done in `setUp`..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362487
--- Diff: solr/core/src/test/org/apache/solr/cloud/ShardRoutingTest.java ---
@@ -351,8 +334,8 @@ void doDBQ(String q, String... reqParams) throws Exception {
}
@Override
- public void tearDown() throws Exception {
- super.tearDown();
+ public void distribTearDown() throws Exception {
--- End diff --
Is this override necessary? Without it, the call would just resolve to the super class anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/121#discussion_r22362427
--- Diff: solr/core/src/test/org/apache/solr/cloud/MigrateRouteKeyTest.java ---
@@ -77,7 +75,7 @@ public void tearDown() throws Exception {
if (controlClientCloud != null) {
controlClientCloud.shutdown();
}
- super.tearDown();
+ super.distribTearDown();
--- End diff --
super.distribTearDown() is called twice in this method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by andyetitmoves <gi...@git.apache.org>.
Github user andyetitmoves commented on the pull request:
https://github.com/apache/lucene-solr/pull/121#issuecomment-68439138
Thanks for the comments @madrob, I have updated with some revisions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Use JUnit rules instead of inheritance w...
Posted by andyetitmoves <gi...@git.apache.org>.
Github user andyetitmoves closed the pull request at:
https://github.com/apache/lucene-solr/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org