You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "abeizn (via GitHub)" <gi...@apache.org> on 2024/01/26 02:30:24 UTC
[PR] fix: github run api page<35 limit [incubator-devlake]
abeizn opened a new pull request, #6876:
URL: https://github.com/apache/incubator-devlake/pull/6876
### Summary
fix: github run api page<35 limit.
github api bug, only collect page < 35 data, otherwise will get nil response
example: https://api.github.com/repos/apache/incubator-devlake/actions/runs?per_page=30&page=35&status=completed
### Does this close any open issues?
Closes na
### Screenshots
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: github run api page<35 limit [incubator-devlake]
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn merged PR #6876:
URL: https://github.com/apache/incubator-devlake/pull/6876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: github run api page<35 limit [incubator-devlake]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6876:
URL: https://github.com/apache/incubator-devlake/pull/6876#issuecomment-1911327747
🤖 cherry pick finished successfully 🎉!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: github run api page<35 limit [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on code in PR #6876:
URL: https://github.com/apache/incubator-devlake/pull/6876#discussion_r1467173437
##########
backend/plugins/github/tasks/cicd_run_collector.go:
##########
@@ -80,7 +75,9 @@ func CollectRuns(taskCtx plugin.SubTaskContext) errors.Error {
UrlTemplate: "repos/{{ .Params.Name }}/actions/runs",
Query: func(reqData *helper.RequestData, createdAfter *time.Time) (url.Values, errors.Error) {
query := url.Values{}
- query.Set("status", "completed")
+ // github api bug, only collect page < 35 data, otherwise will get nil response
Review Comment:
GitHub API returns only the first 34 pages (with a size of 30) when specifying `status=compleleted`, try the following API request to verify the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: github run api page<35 limit [incubator-devlake]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6876:
URL: https://github.com/apache/incubator-devlake/pull/6876#issuecomment-1911327306
🤖 cherry pick finished successfully 🎉!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org