[jira] [Commented] (ARTEMIS-1327) Support checked exceptions from ActiveMQServerPlugin

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116685#comment-16116685 ] 

ASF GitHub Bot commented on ARTEMIS-1327:
-----------------------------------------

GitHub user cshannon opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1445

    ARTEMIS-1327 - Support checked exceptions in ActiveMQServerPlugin

    This will allow plugin writers to use checked exceptions when writing
    plugins

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1327

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1445.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1445
    
----
commit 16843d54bc833d61bb879fa47f9832147b454d97
Author: Christopher L. Shannon (cshannon) <ch...@gmail.com>
Date:   2017-08-07T14:49:46Z

    ARTEMIS-1327 - Support checked exceptions in ActiveMQServerPlugin
    
    This will allow plugin writers to use checked exceptions when writing
    plugins

----


> Support checked exceptions from ActiveMQServerPlugin
> ----------------------------------------------------
>
>                 Key: ARTEMIS-1327
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1327
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>             Fix For: 2.3.0
>
>
> After I was writing a couple custom plugins I realized it would be beneficial to support checked exceptions.  This makes error handling simpler for plugin writers as they can throw various exceptions and not have to always wrap them in a RuntimeException.  Almost every place in the broker where plugin methods are currently called already support handling checked Exceptions so this is pretty simply and mostly just need to add a "throws Exception" to each of the methods in the ActiveMQServerPlugin interface and make sure the methods used to execute the plugin methods also support it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)