You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Joep Rottinghuis (JIRA)" <ji...@apache.org> on 2011/06/21 19:57:47 UTC
[jira] [Created] (MAPREDUCE-2610) Inconsistent API
JobClient.getQueueAclsForCurrentUser
Inconsistent API JobClient.getQueueAclsForCurrentUser
-----------------------------------------------------
Key: MAPREDUCE-2610
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2610
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: client
Affects Versions: 0.20.205.0
Reporter: Joep Rottinghuis
Client needs access to the current user's queue name.
Public method JobClient.getQueueAclsForCurrentUser() returns QueueAclsInfo[].
The QueueAclsInfo class has default access. A public method should not return a package-private class.
The QueueAclsInfo class, its two constructors, getQueueName, and getOperations methods should be public.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2610) Inconsistent API
JobClient.getQueueAclsForCurrentUser
Posted by "Joep Rottinghuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095557#comment-13095557 ]
Joep Rottinghuis commented on MAPREDUCE-2610:
---------------------------------------------
Don't remember off the top of my head. Will check and get back to you.
> Inconsistent API JobClient.getQueueAclsForCurrentUser
> -----------------------------------------------------
>
> Key: MAPREDUCE-2610
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2610
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.205.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Attachments: MAPREDUCE-2610.patch
>
>
> Client needs access to the current user's queue name.
> Public method JobClient.getQueueAclsForCurrentUser() returns QueueAclsInfo[].
> The QueueAclsInfo class has default access. A public method should not return a package-private class.
> The QueueAclsInfo class, its two constructors, getQueueName, and getOperations methods should be public.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MAPREDUCE-2610) Inconsistent API
JobClient.getQueueAclsForCurrentUser
Posted by "Joep Rottinghuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joep Rottinghuis reassigned MAPREDUCE-2610:
-------------------------------------------
Assignee: Joep Rottinghuis
> Inconsistent API JobClient.getQueueAclsForCurrentUser
> -----------------------------------------------------
>
> Key: MAPREDUCE-2610
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2610
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.205.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Attachments: MAPREDUCE-2610.patch
>
>
> Client needs access to the current user's queue name.
> Public method JobClient.getQueueAclsForCurrentUser() returns QueueAclsInfo[].
> The QueueAclsInfo class has default access. A public method should not return a package-private class.
> The QueueAclsInfo class, its two constructors, getQueueName, and getOperations methods should be public.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2610) Inconsistent API
JobClient.getQueueAclsForCurrentUser
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095518#comment-13095518 ]
Arun C Murthy commented on MAPREDUCE-2610:
------------------------------------------
Joep, so this isn't a problem for trunk?
> Inconsistent API JobClient.getQueueAclsForCurrentUser
> -----------------------------------------------------
>
> Key: MAPREDUCE-2610
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2610
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.205.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Attachments: MAPREDUCE-2610.patch
>
>
> Client needs access to the current user's queue name.
> Public method JobClient.getQueueAclsForCurrentUser() returns QueueAclsInfo[].
> The QueueAclsInfo class has default access. A public method should not return a package-private class.
> The QueueAclsInfo class, its two constructors, getQueueName, and getOperations methods should be public.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2610) Inconsistent API
JobClient.getQueueAclsForCurrentUser
Posted by "Joep Rottinghuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052718#comment-13052718 ]
Joep Rottinghuis commented on MAPREDUCE-2610:
---------------------------------------------
Note that this class is deprecated on trunk (see MAPREDUCE-777), but its replacement in the o.a.h.mapreduce package does have public access to get to the queue and operations.
> Inconsistent API JobClient.getQueueAclsForCurrentUser
> -----------------------------------------------------
>
> Key: MAPREDUCE-2610
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2610
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.205.0
> Reporter: Joep Rottinghuis
>
> Client needs access to the current user's queue name.
> Public method JobClient.getQueueAclsForCurrentUser() returns QueueAclsInfo[].
> The QueueAclsInfo class has default access. A public method should not return a package-private class.
> The QueueAclsInfo class, its two constructors, getQueueName, and getOperations methods should be public.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2610) Inconsistent API
JobClient.getQueueAclsForCurrentUser
Posted by "Joep Rottinghuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joep Rottinghuis updated MAPREDUCE-2610:
----------------------------------------
Status: Patch Available (was: Open)
> Inconsistent API JobClient.getQueueAclsForCurrentUser
> -----------------------------------------------------
>
> Key: MAPREDUCE-2610
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2610
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.205.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Attachments: MAPREDUCE-2610.patch
>
>
> Client needs access to the current user's queue name.
> Public method JobClient.getQueueAclsForCurrentUser() returns QueueAclsInfo[].
> The QueueAclsInfo class has default access. A public method should not return a package-private class.
> The QueueAclsInfo class, its two constructors, getQueueName, and getOperations methods should be public.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2610) Inconsistent API
JobClient.getQueueAclsForCurrentUser
Posted by "Joep Rottinghuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095578#comment-13095578 ]
Joep Rottinghuis commented on MAPREDUCE-2610:
---------------------------------------------
This is also not a problem on 0.22, which is the same as trunk in this regard.
Both getQueueName and getOperations are public in the new class.
> Inconsistent API JobClient.getQueueAclsForCurrentUser
> -----------------------------------------------------
>
> Key: MAPREDUCE-2610
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2610
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.205.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Attachments: MAPREDUCE-2610.patch
>
>
> Client needs access to the current user's queue name.
> Public method JobClient.getQueueAclsForCurrentUser() returns QueueAclsInfo[].
> The QueueAclsInfo class has default access. A public method should not return a package-private class.
> The QueueAclsInfo class, its two constructors, getQueueName, and getOperations methods should be public.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2610) Inconsistent API
JobClient.getQueueAclsForCurrentUser
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098672#comment-13098672 ]
Mahadev konar commented on MAPREDUCE-2610:
------------------------------------------
+1 for the patch. Is this marked for 205?
> Inconsistent API JobClient.getQueueAclsForCurrentUser
> -----------------------------------------------------
>
> Key: MAPREDUCE-2610
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2610
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.205.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Attachments: MAPREDUCE-2610.patch
>
>
> Client needs access to the current user's queue name.
> Public method JobClient.getQueueAclsForCurrentUser() returns QueueAclsInfo[].
> The QueueAclsInfo class has default access. A public method should not return a package-private class.
> The QueueAclsInfo class, its two constructors, getQueueName, and getOperations methods should be public.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2610) Inconsistent API
JobClient.getQueueAclsForCurrentUser
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated MAPREDUCE-2610:
-------------------------------------
Resolution: Fixed
Fix Version/s: 0.20.205.0
Status: Resolved (was: Patch Available)
I just committed this. Thanks Joep!
> Inconsistent API JobClient.getQueueAclsForCurrentUser
> -----------------------------------------------------
>
> Key: MAPREDUCE-2610
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2610
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.205.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Fix For: 0.20.205.0
>
> Attachments: MAPREDUCE-2610.patch
>
>
> Client needs access to the current user's queue name.
> Public method JobClient.getQueueAclsForCurrentUser() returns QueueAclsInfo[].
> The QueueAclsInfo class has default access. A public method should not return a package-private class.
> The QueueAclsInfo class, its two constructors, getQueueName, and getOperations methods should be public.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2610) Inconsistent API
JobClient.getQueueAclsForCurrentUser
Posted by "Priyo Mustafi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Priyo Mustafi updated MAPREDUCE-2610:
-------------------------------------
Attachment: MAPREDUCE-2610.patch
Patch file
> Inconsistent API JobClient.getQueueAclsForCurrentUser
> -----------------------------------------------------
>
> Key: MAPREDUCE-2610
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2610
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.205.0
> Reporter: Joep Rottinghuis
> Attachments: MAPREDUCE-2610.patch
>
>
> Client needs access to the current user's queue name.
> Public method JobClient.getQueueAclsForCurrentUser() returns QueueAclsInfo[].
> The QueueAclsInfo class has default access. A public method should not return a package-private class.
> The QueueAclsInfo class, its two constructors, getQueueName, and getOperations methods should be public.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2610) Inconsistent API
JobClient.getQueueAclsForCurrentUser
Posted by "Joep Rottinghuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095575#comment-13095575 ]
Joep Rottinghuis commented on MAPREDUCE-2610:
---------------------------------------------
No this is not a problem on trunk.
org/apache/hadoop/mapred/QueueAclsInfo.java
is deprecated and the new
org/apache/hadoop/mapreduce/QueueAclsInfo.java
does not suffer from the same problems.
As you know both can be found in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/
> Inconsistent API JobClient.getQueueAclsForCurrentUser
> -----------------------------------------------------
>
> Key: MAPREDUCE-2610
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2610
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 0.20.205.0
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Attachments: MAPREDUCE-2610.patch
>
>
> Client needs access to the current user's queue name.
> Public method JobClient.getQueueAclsForCurrentUser() returns QueueAclsInfo[].
> The QueueAclsInfo class has default access. A public method should not return a package-private class.
> The QueueAclsInfo class, its two constructors, getQueueName, and getOperations methods should be public.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira