You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/02 17:08:58 UTC

[jira] [Commented] (THRIFT-3886) PHP cross test client returns 0 even when failing

    [ https://issues.apache.org/jira/browse/THRIFT-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715669#comment-15715669 ] 

ASF GitHub Bot commented on THRIFT-3886:
----------------------------------------

Github user zhaakhi commented on the issue:

    https://github.com/apache/thrift/pull/1131
  
    I think the tests should pass on current master if re-run... It would be nice to have this merged so future pull requests can include tests.


> PHP cross test client returns 0 even when failing
> -------------------------------------------------
>
>                 Key: THRIFT-3886
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3886
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library, Test Suite
>            Reporter: Aki Sukegawa
>
> PHP cross test client never fails on invalid values.
> update:
> Results for primitive values are now validated after PR #1054.
> Structs, containers, etc are still affected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)