You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/01 14:20:47 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #37363: [SPARK-39935][SQL][TESTS] Switch `validateParsingError()` onto `checkError()`
MaxGekk opened a new pull request, #37363:
URL: https://github.com/apache/spark/pull/37363
### What changes were proposed in this pull request?
1. Re-implemented `validateParsingError()` using `checkError()`.
2. Removed `checkParsingError()` and replaced by `checkError()`.
### Why are the changes needed?
1. To prepare test infra for testing of query contexts.
3. To check message parameters instead of entire text message. This PR is some kind of follow up of https://github.com/apache/spark/pull/36693 and https://github.com/apache/spark/pull/37322.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
By running the modified test suites:
```
$ build/sbt -Phive -Phive-thriftserver "test:testOnly *TruncateTableParserSuite"
$ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *ShowPartitionsParserSuite"
$ build/sbt "sql/testOnly *QueryParsingErrorsSuite"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37363: [SPARK-39935][SQL][TESTS] Switch `validateParsingError()` onto `checkError()`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37363:
URL: https://github.com/apache/spark/pull/37363#issuecomment-1201502303
@gengliangwang @cloud-fan @anchovYu Could you review this PR, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #37363: [SPARK-39935][SQL][TESTS] Switch `validateParsingError()` onto `checkError()`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #37363: [SPARK-39935][SQL][TESTS] Switch `validateParsingError()` onto `checkError()`
URL: https://github.com/apache/spark/pull/37363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37363: [SPARK-39935][SQL][TESTS] Switch `validateParsingError()` onto `checkError()`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37363:
URL: https://github.com/apache/spark/pull/37363#issuecomment-1202091784
I think the SparkR failure is not related to the changes. I am going to merge this PR to master. Thank you, @cloud-fan @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org