Re: Review Request 57499: Sqoop incremental import - NULL column updates are not pulled into HBase table

[Jilani Shaik <ji...@gmail.com>]

Hi,

Please let me know if anything required for this review and Jira request.

Thanks,
Jilani

On Sun, Apr 9, 2017 at 12:49 PM, Jilani Shaik <ji...@gmail.com> wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57499/
> -----------------------------------------------------------
>
> (Updated April 9, 2017, 5:49 p.m.)
>
>
> Review request for Sqoop, Boglarka Egyed, Attila Szabo, and Anna Szonyi.
>
>
> Changes
> -------
>
> Uploaded patch for below
>
>  Could you please use more verbose naming here instead of "OverwriteT" and
> "OverwriteF". It makes difficult to undersand the test ...
>  I would suggest to use a parameter here too instead of a hardcoded value.
>  There is no colNames input parameter in the method signature.
>
> and removed incorrect indention
>
>
> Bugs: SQOOP-3149
>     https://issues.apache.org/jira/browse/SQOOP-3149
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> HBase delete is added as part of incremental data import, Modified the
> return type of method which is responsible for holding list of Put objects
> to List of Mutation objects and at the time of execution of insert or
> delete using the type of object in Mutation, executed the actaul operation
> either insert or delete.
>
> Jira ticket for the same: https://issues.apache.org/jira/browse/SQOOP-3149
>
> Similar ticket to above:  SQOOP-3125
>
>
> Diffs (updated)
> -----
>
>   src/java/org/apache/sqoop/hbase/HBasePutProcessor.java fdbe1276
>   src/java/org/apache/sqoop/hbase/PutTransformer.java 533467e5
>   src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java 363e1456
>   src/java/org/apache/sqoop/mapreduce/HBaseBulkImportMapper.java 58ccee7b
>   src/test/com/cloudera/sqoop/hbase/HBaseImportTest.java fa14a013
>   src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java a054eb66
>   src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 6310a398
>
>
> Diff: https://reviews.apache.org/r/57499/diff/4/
>
> Changes: https://reviews.apache.org/r/57499/diff/3-4/
>
>
> Testing
> -------
>
> Executed with jar prepared with these changes into hadoop cluster and
> tested bot import and then incremental import.
>
>
> File Attachments
> ----------------
>
> HBase delete support for incremental import
>   https://reviews.apache.org/media/uploaded/files/2017/03/
> 11/5b1895fd-4c6b-42fa-8a92-4e093153e370__hbase_delete_
> support_in_incremental_import
> updated with unit test and based on below suggestions
>   https://reviews.apache.org/media/uploaded/files/2017/03/
> 22/708f63ba-2d8a-4a47-ab67-c1d2776354fd__hbase_delete_
> support_in_incremental_unit_test_also
>
>
> Thanks,
>
> Jilani Shaik
>
>