You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/14 04:10:12 UTC
[GitHub] [skywalking-banyandb] hanahmily opened a new pull request #17: Add series event
hanahmily opened a new pull request #17:
URL: https://github.com/apache/skywalking-banyandb/pull/17
Introduce the series event in order to help liaison to composite `seriesID`. This event contains filed names that indicates which fields should be included for building the `seriesID`
Signed-off-by: Gao Hongtao <ha...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on a change in pull request #17: Add series event
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-banyandb/pull/17#discussion_r669309700
##########
File path: api/event/discovery.go
##########
@@ -32,13 +32,22 @@ var (
ID: ShardEventKindVersion.String(),
Type: bus.ChTypeUnidirectional,
}
+ SeriesEventKindVersion = common.KindVersion{
+ Version: "v1",
+ Kind: "event-series",
+ }
+ TopicSeriesEvent = bus.Topic{
Review comment:
make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] lujiajing1126 commented on a change in pull request #17: Add series event
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-banyandb/pull/17#discussion_r669305744
##########
File path: api/event/discovery.go
##########
@@ -32,13 +32,22 @@ var (
ID: ShardEventKindVersion.String(),
Type: bus.ChTypeUnidirectional,
}
+ SeriesEventKindVersion = common.KindVersion{
+ Version: "v1",
+ Kind: "event-series",
+ }
+ TopicSeriesEvent = bus.Topic{
Review comment:
Since we have `bus.Uni` method, we should use them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #17: Add series event
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on pull request #17:
URL: https://github.com/apache/skywalking-banyandb/pull/17#issuecomment-879608826
LGTM.
As I understand, these events are defined for write, not query/read, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily merged pull request #17: Add series event
Posted by GitBox <gi...@apache.org>.
hanahmily merged pull request #17:
URL: https://github.com/apache/skywalking-banyandb/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #17: Add series event
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #17:
URL: https://github.com/apache/skywalking-banyandb/pull/17#issuecomment-879611795
> LGTM.
>
> As I understand, these events are defined for write, not query/read, right?
yep, for the query scenario, the liaison will choose an arbitrary shard to send the request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org