Re: [PR] fix: Fix SupersetClient.postForm calls when SUPERSET_APP_ROOT defined [superset]

["sadpandajoe (via GitHub)" <gi...@apache.org>]

sadpandajoe commented on code in PR #38069:
URL: https://github.com/apache/superset/pull/38069#discussion_r4170578124


##########
superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts:
##########
@@ -696,7 +696,7 @@ describe('SupersetClientClass', () => {
       client = new SupersetClientClass({ protocol, host, guestToken });
       await client.init();
 
-      await client.postForm(mockPostFormUrl, {});
+      await client.postForm({ url: mockPostFormUrl, payload: {} });

Review Comment:
   The `url` cases check tokens and payloads but never the form action, so forwarding a resolved URL as an endpoint again would double the app-root prefix while these tests still pass. Could we add a non-empty `appRoot` case for `postForm({ url: "/prefix/post_form/url", payload: {} })` and assert that the submitted action stays `/prefix/post_form/url`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org