You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/05 04:17:56 UTC
[GitHub] [rocketmq-client-go] NeonToo opened a new pull request, #852: bugfix rebalance is not paused after suspend and rebalance not trigge…
NeonToo opened a new pull request, #852:
URL: https://github.com/apache/rocketmq-client-go/pull/852
## What is the purpose of the change
[BUGFIX] reset offset not work correctly
- rebalance is not paused after suspend
- pc.removeUnnecessaryMessageQueue & processQueueTable.Delete not work as expected since the judege on exist always return false
## Brief changelog
- pause rebalance after suspend
- use copyPc to operate pc.removeUnnecessaryMessageQueue & processQueueTable.Delete
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] duhenglucky merged pull request #852: bugfix rebalance is not paused after suspend and rebalance not trigge…
Posted by GitBox <gi...@apache.org>.
duhenglucky merged PR #852:
URL: https://github.com/apache/rocketmq-client-go/pull/852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] maqingxiang commented on pull request #852: bugfix rebalance is not paused after suspend and rebalance not trigge…
Posted by GitBox <gi...@apache.org>.
maqingxiang commented on PR #852:
URL: https://github.com/apache/rocketmq-client-go/pull/852#issuecomment-1177332388
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org