[GitHub] [incubator-pinot] sunithabeeram opened a new pull request #4155: Move pinot-filesystem into pinot-common

[GitBox <gi...@apache.org>]

sunithabeeram opened a new pull request #4155: Move pinot-filesystem into pinot-common
URL: https://github.com/apache/incubator-pinot/pull/4155
 
 
   We would like to start adding annotations to classes that are expected to be extended by the users. See https://github.com/apache/incubator-pinot/issues/4031.
   
   #4063 added the annotations to pinot-common. However it turns out that we currently have pinot-filesystem as the base module (pinot-common depends on it). To be able to annotate filesystem related classes (which forms a big part of extensibility for Pinot) one option is to merge filesystem into common. (Other option is to move the annotations to filesystem or perhaps another module below filesystem, but both seem to be far from ideal.)
   
   Compatibility considerations:
   - This change is backwards incompatible. Users explicitly extending pinot-filesystem will encounter compile-time failures. The fix would be to exclude pinot-filesystem dependency in the corresponding pom file. We could add this to next release's release notes (and/or bump up the version number so its more explicit).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org