[jira] [Commented] (KARAF-5055) Service wrapper shutdown timeout is not taken into account when Karaf's JVM is 'Stopped'

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936237#comment-15936237 ] 

ASF GitHub Bot commented on KARAF-5055:
---------------------------------------

GitHub user johnpoth opened a pull request:

    https://github.com/apache/karaf/pull/290

    KARAF-5055: use karaf shutdown timeout when notifying the service wra…

    …pper
    
    https://issues.apache.org/jira/browse/KARAF-5055
    
    Instead of notifying the service wrapper every 5 seconds that we are awaiting shutdown for 5*2 seconds or so, I propose to notify once the service wrapper that we are shutting down using the Karaf shutdown timeout.
    
    I've tested both when the timeout is reached(ungraceful shutdown) and when it's not (graceful shutdown). Both cases yield expected behavior.
    
    Thanks!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/johnpoth/karaf KARAF-5055

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #290
    
----
commit 79f78a8a3c6621f7e31aea8476a1b441404e4073
Author: jpoth <po...@gmail.com>
Date:   2017-03-22T12:43:08Z

    KARAF-5055: use karaf shutdown timeout when notifying the service wrapper

----


> Service wrapper shutdown timeout is not taken into account when Karaf's JVM is 'Stopped'
> ----------------------------------------------------------------------------------------
>
>                 Key: KARAF-5055
>                 URL: https://issues.apache.org/jira/browse/KARAF-5055
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-os-integration
>            Reporter: John Poth
>
> To reproduce, install the attached blueprint and start Karaf using the Service Wrapper. Then:
> \\
> * bin/karaf-service stop and then immediately
> * kill -STOP $karaf_jvm_pid
> You'll notice that the Karaf JVM will be killed using SIGTERM regardless of the shutdown timeouts set in both the Service wrapper settings file (karaf-wrapper.conf) and karaf. This doesn't allow for graceful shutdown.
> I can provide a PR.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)