You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by en...@apache.org on 2025/12/02 13:30:51 UTC

(superset) branch enxdev/fix/alert-report-modal-filters created (now 6a69f71685)

This is an automated email from the ASF dual-hosted git repository.

enzomartellucci pushed a change to branch enxdev/fix/alert-report-modal-filters
in repository https://gitbox.apache.org/repos/asf/superset.git


      at 6a69f71685 style(alert-report-filters) adjust vertical alignments

This branch includes the following new commits:

     new e91985fa9c fix(alerts-report-modal): dashboard filter reappears in dropdown after clearing
     new 6a69f71685 style(alert-report-filters) adjust vertical alignments

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(superset) 02/02: style(alert-report-filters) adjust vertical alignments

Posted by en...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

enzomartellucci pushed a commit to branch enxdev/fix/alert-report-modal-filters
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 6a69f71685e47b83fa56578714ea991b53f6088c
Author: Enzo Martellucci <en...@gmail.com>
AuthorDate: Tue Dec 2 13:57:34 2025 +0100

    style(alert-report-filters) adjust vertical alignments
---
 superset-frontend/src/features/alerts/AlertReportModal.tsx | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/src/features/alerts/AlertReportModal.tsx b/superset-frontend/src/features/alerts/AlertReportModal.tsx
index 3d54edaaf5..c3e875ecc7 100644
--- a/superset-frontend/src/features/alerts/AlertReportModal.tsx
+++ b/superset-frontend/src/features/alerts/AlertReportModal.tsx
@@ -324,6 +324,7 @@ export const StyledInputContainer = styled.div`
 
       .filters-container {
         display: flex;
+        align-items: flex-start;
         margin: ${theme.sizeUnit * 2}px 0;
       }
 
@@ -356,7 +357,7 @@ export const StyledInputContainer = styled.div`
 
       .filters-delete {
         display: flex;
-        margin-top: ${theme.sizeUnit * 8}px;
+        margin-top: ${theme.sizeUnit * 10}px;
         margin-left: ${theme.sizeUnit * 4}px;
       }
 
@@ -2387,7 +2388,9 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
                                         )
                                       }
                                       onClear={() => {
-                                        const updatedFilters = [...nativeFilterData];
+                                        const updatedFilters = [
+                                          ...nativeFilterData,
+                                        ];
                                         updatedFilters[idx] = {
                                           nativeFilterId: null,
                                           columnLabel: '',


(superset) 01/02: fix(alerts-report-modal): dashboard filter reappears in dropdown after clearing

Posted by en...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

enzomartellucci pushed a commit to branch enxdev/fix/alert-report-modal-filters
in repository https://gitbox.apache.org/repos/asf/superset.git

commit e91985fa9c2ffbccf81b45cae0e99c3c1d9c67c5
Author: Enzo Martellucci <en...@gmail.com>
AuthorDate: Tue Dec 2 13:40:17 2025 +0100

    fix(alerts-report-modal): dashboard filter reappears in dropdown after clearing
---
 superset-frontend/src/features/alerts/AlertReportModal.tsx | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/superset-frontend/src/features/alerts/AlertReportModal.tsx b/superset-frontend/src/features/alerts/AlertReportModal.tsx
index 69ab65796d..3d54edaaf5 100644
--- a/superset-frontend/src/features/alerts/AlertReportModal.tsx
+++ b/superset-frontend/src/features/alerts/AlertReportModal.tsx
@@ -2387,10 +2387,15 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
                                         )
                                       }
                                       onClear={() => {
-                                        // reset filter values on filter clear
-                                        nativeFilterData[idx].columnName = '';
-                                        nativeFilterData[idx].filterName = '';
-                                        nativeFilterData[idx].filterValues = [];
+                                        const updatedFilters = [...nativeFilterData];
+                                        updatedFilters[idx] = {
+                                          nativeFilterId: null,
+                                          columnLabel: '',
+                                          columnName: '',
+                                          filterName: '',
+                                          filterValues: [],
+                                        };
+                                        setNativeFilterData(updatedFilters);
                                       }}
                                       css={css`
                                         flex: 1;