You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/01/17 20:19:48 UTC

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4305: Prevents line breaks in delivery service remapText field (UI and API)

rawlinp commented on a change in pull request #4305: Prevents line breaks in delivery service remapText field (UI and API)
URL: https://github.com/apache/trafficcontrol/pull/4305#discussion_r368119404
 
 

 ##########
 File path: traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
 ##########
 @@ -534,7 +534,8 @@ <h3>Current Value</h3>
                         </div>
                         </label>
                         <div class="col-md-10 col-sm-10 col-xs-12">
-                            <textarea id="remapText" name="remapText" class="form-control" ng-model="deliveryService.remapText" rows="3"></textarea>
+                            <textarea id="remapText" name="remapText" class="form-control" ng-model="deliveryService.remapText" ng-pattern="/^[^\n\r]*$/" rows="3"></textarea>
 
 Review comment:
   I think because it's easier to read long inputs with text-wrapping.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services