You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "bryopsida (via GitHub)" <gi...@apache.org> on 2023/05/14 13:07:40 UTC

[GitHub] [couchdb-helm] bryopsida opened a new pull request, #117: Add pdb

bryopsida opened a new pull request, #117:
URL: https://github.com/apache/couchdb-helm/pull/117

   #### What this PR does / why we need it:
   Adds a optional PDB to make node drains/cordons safer
   
   #### Which issue this PR fixes
     - fixes #49
   
   #### Special notes for your reviewer:
   
   #### Checklist
   [Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.
   - [x] Chart Version bumped
   - [ ] e2e tests pass
   - [x] Variables are documented in the README.md
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-helm] bryopsida commented on pull request #117: Add pdb

Posted by "bryopsida (via GitHub)" <gi...@apache.org>.
bryopsida commented on PR #117:
URL: https://github.com/apache/couchdb-helm/pull/117#issuecomment-1548798915

   > thanks for the PR @bryopsida. It seems that CI is failing, though I'm not entirely sure why - it passes locally for me so is perhaps a timing issue.
   
   I tested out a white space only change here: https://github.com/bryopsida/couchdb-helm/actions/runs/4986433003 and that worked so it seems isolated to this branch.
   
   When I have some more time I'll try and isolate what's going on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-helm] willholley commented on pull request #117: Add pdb

Posted by "willholley (via GitHub)" <gi...@apache.org>.
willholley commented on PR #117:
URL: https://github.com/apache/couchdb-helm/pull/117#issuecomment-1548177079

   thanks for the PR @bryopsida. It seems that CI is failing, though I'm not entirely sure why - it passes locally for me so is perhaps a timing issue. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-helm] willholley merged pull request #117: Add pdb

Posted by "willholley (via GitHub)" <gi...@apache.org>.
willholley merged PR #117:
URL: https://github.com/apache/couchdb-helm/pull/117


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-helm] bryopsida commented on pull request #117: Add pdb

Posted by "bryopsida (via GitHub)" <gi...@apache.org>.
bryopsida commented on PR #117:
URL: https://github.com/apache/couchdb-helm/pull/117#issuecomment-1555906916

   @willholley looks like I was missing a null check on podDisruptionBudget, I was counting on the default value being present but looks like that's not the case in CI.
   
   I tested it here https://github.com/bryopsida/couchdb-helm/actions/runs/5032284491 and here https://github.com/bryopsida/couchdb-helm/actions/runs/5032313655 and it worked.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org