You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/12 10:19:50 UTC
[GitHub] [airflow] potiuk opened a new pull request #13632: Providers are not installed from PyPI when testing local files
potiuk opened a new pull request #13632:
URL: https://github.com/apache/airflow/pull/13632
When testing locally generated providers, we should skip installing
them from PyPI because some providers might be added which are
not yet in PyPI.
There was a mistake in copy&pasted workflow which caused that
the providers have been first installed from PyPI and then
uninstalled, but in case of a new providers added, this
caused a failure as newly added providers failed to install
from PyPI.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13632: Providers are not installed from PyPI when testing local files
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13632:
URL: https://github.com/apache/airflow/pull/13632#issuecomment-758567829
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13632: Providers are not installed from PyPI when testing local files
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13632:
URL: https://github.com/apache/airflow/pull/13632#issuecomment-758688452
Ah yeah. That was cancelled as I re-pushed after merging yet another fix for my and Ash's cross-merged submodule/workflow split commits #13633
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13632: Providers are not installed from PyPI when testing local files
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13632:
URL: https://github.com/apache/airflow/pull/13632#issuecomment-758558920
CC: @kanthi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13632: Providers are not installed from PyPI when testing local files
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13632:
URL: https://github.com/apache/airflow/pull/13632#issuecomment-758619893
> Testing it here: https://github.com/potiuk/airflow/actions/runs/479945895 when it passes the provider test steps I will merge it
hmm weird -- that one failed with "Error: Failed to resolve action download info."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13632: Providers are not installed from PyPI when testing local files
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13632:
URL: https://github.com/apache/airflow/pull/13632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13632: Providers are not installed from PyPI when testing local files
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13632:
URL: https://github.com/apache/airflow/pull/13632#issuecomment-758690341
I tested it here: https://github.com/potiuk/airflow/actions/runs/480205120
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13632: Providers are not installed from PyPI when testing local files
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13632:
URL: https://github.com/apache/airflow/pull/13632#issuecomment-758560126
Testing it here: https://github.com/potiuk/airflow/actions/runs/479945895 when it passes the provider test steps I will merge it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org