You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Bryan Higgins <br...@bryanhiggins.net> on 2013/11/12 21:22:25 UTC
Review Request 15461: config_parser - handle duplicates with children and
text when merging
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15461/
-----------------------------------------------------------
Review request for cordova and Jeffrey Heifetz.
Repository: cordova-cli
Description
-------
https://issues.apache.org/jira/browse/CB-5364
Diffs
-----
src/config_parser.js 11667d3
Diff: https://reviews.apache.org/r/15461/diff/
Testing
-------
Thanks,
Bryan Higgins
Re: Review Request 15461: config_parser - handle duplicates with children
and text when merging
Posted by Jeffrey Heifetz <jh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15461/#review28753
-----------------------------------------------------------
Ship it!
Looks great to me, just missing updates to the unit tests
- Jeffrey Heifetz
On Nov. 12, 2013, 8:22 p.m., Bryan Higgins wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15461/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2013, 8:22 p.m.)
>
>
> Review request for cordova and Jeffrey Heifetz.
>
>
> Repository: cordova-cli
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/CB-5364
>
>
> Diffs
> -----
>
> src/config_parser.js 11667d3
>
> Diff: https://reviews.apache.org/r/15461/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bryan Higgins
>
>