You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xerces.apache.org by am...@apache.org on 2005/12/20 14:53:50 UTC

svn commit: r357990 - in /xerces/c/trunk/src/xercesc/dom/impl: DOMNodeListImpl.cpp DOMNodeListImpl.hpp DOMParentNode.cpp

Author: amassari
Date: Tue Dec 20 05:53:44 2005
New Revision: 357990

URL: http://svn.apache.org/viewcvs?rev=357990&view=rev
Log:
Removed unnecessary casts inside DOMNodeList

Modified:
    xerces/c/trunk/src/xercesc/dom/impl/DOMNodeListImpl.cpp
    xerces/c/trunk/src/xercesc/dom/impl/DOMNodeListImpl.hpp
    xerces/c/trunk/src/xercesc/dom/impl/DOMParentNode.cpp

Modified: xerces/c/trunk/src/xercesc/dom/impl/DOMNodeListImpl.cpp
URL: http://svn.apache.org/viewcvs/xerces/c/trunk/src/xercesc/dom/impl/DOMNodeListImpl.cpp?rev=357990&r1=357989&r2=357990&view=diff
==============================================================================
--- xerces/c/trunk/src/xercesc/dom/impl/DOMNodeListImpl.cpp (original)
+++ xerces/c/trunk/src/xercesc/dom/impl/DOMNodeListImpl.cpp Tue Dec 20 05:53:44 2005
@@ -30,7 +30,7 @@
 //   this implementation is too stupid - needs a cache of some kind.
 //
 
-DOMNodeListImpl::DOMNodeListImpl(DOMNode *node)
+DOMNodeListImpl::DOMNodeListImpl(DOMParentNode *node)
 :   fNode(node)
 {
 }
@@ -45,7 +45,7 @@
 XMLSize_t DOMNodeListImpl::getLength() const{
     XMLSize_t count = 0;
     if (fNode) {
-        DOMNode *node = castToParentImpl(fNode)->fFirstChild;
+        DOMNode *node = fNode->fFirstChild;
         while(node != 0){
             ++count;
             node = castToChildImpl(node)->nextSibling;
@@ -59,7 +59,7 @@
 
 DOMNode *DOMNodeListImpl::item(XMLSize_t index) const{
     if (fNode) {
-        DOMNode *node = castToParentImpl(fNode)->fFirstChild;
+        DOMNode *node = fNode->fFirstChild;
         for(XMLSize_t i=0; i<index && node!=0; ++i)
             node = castToChildImpl(node)->nextSibling;
         return node;

Modified: xerces/c/trunk/src/xercesc/dom/impl/DOMNodeListImpl.hpp
URL: http://svn.apache.org/viewcvs/xerces/c/trunk/src/xercesc/dom/impl/DOMNodeListImpl.hpp?rev=357990&r1=357989&r2=357990&view=diff
==============================================================================
--- xerces/c/trunk/src/xercesc/dom/impl/DOMNodeListImpl.hpp (original)
+++ xerces/c/trunk/src/xercesc/dom/impl/DOMNodeListImpl.hpp Tue Dec 20 05:53:44 2005
@@ -45,13 +45,13 @@
 
 XERCES_CPP_NAMESPACE_BEGIN
 
-
+class DOMParentNode;
 class DOMNode;
 
 class CDOM_EXPORT DOMNodeListImpl: public DOMNodeList
 {
 private:
-    DOMNode   *fNode;
+    DOMParentNode   *fNode;
 
     // Unused, and unimplemented constructors, operators, etc.
     DOMNodeListImpl();
@@ -59,7 +59,7 @@
     DOMNodeListImpl & operator = (const DOMNodeListImpl & other);
 
 public:
-    DOMNodeListImpl(DOMNode *node);
+    DOMNodeListImpl(DOMParentNode *node);
     virtual             ~DOMNodeListImpl();
     virtual DOMNode *  item(XMLSize_t index) const;
     virtual XMLSize_t getLength() const;

Modified: xerces/c/trunk/src/xercesc/dom/impl/DOMParentNode.cpp
URL: http://svn.apache.org/viewcvs/xerces/c/trunk/src/xercesc/dom/impl/DOMParentNode.cpp?rev=357990&r1=357989&r2=357990&view=diff
==============================================================================
--- xerces/c/trunk/src/xercesc/dom/impl/DOMParentNode.cpp (original)
+++ xerces/c/trunk/src/xercesc/dom/impl/DOMParentNode.cpp Tue Dec 20 05:53:44 2005
@@ -23,7 +23,6 @@
 #include <xercesc/dom/DOMNode.hpp>
 
 #include "DOMDocumentImpl.hpp"
-#include "DOMNodeListImpl.hpp"
 #include "DOMRangeImpl.hpp"
 #include "DOMNodeIteratorImpl.hpp"
 #include "DOMParentNode.hpp"
@@ -32,14 +31,14 @@
 XERCES_CPP_NAMESPACE_BEGIN
 
 DOMParentNode::DOMParentNode(DOMDocument *ownerDoc)
-    : fOwnerDocument(ownerDoc), fFirstChild(0), fChildNodeList(castToNode(this))
+    : fOwnerDocument(ownerDoc), fFirstChild(0), fChildNodeList(this)
 {    
 }
 
 // This only makes a shallow copy, cloneChildren must also be called for a
 // deep clone
 DOMParentNode::DOMParentNode(const DOMParentNode &other)  :
-    fChildNodeList(castToNode(this))
+    fChildNodeList(this)
 {
     this->fOwnerDocument = other.fOwnerDocument;
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@xerces.apache.org
For additional commands, e-mail: commits-help@xerces.apache.org